From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10860 invoked by alias); 27 Apr 2015 21:49:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10830 invoked by uid 89); 27 Apr 2015 21:48:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 27 Apr 2015 21:48:52 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3RLmoWL031332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 27 Apr 2015 17:48:50 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3RLmmtA031012; Mon, 27 Apr 2015 17:48:49 -0400 Message-ID: <553EAEBF.2030406@redhat.com> Date: Tue, 28 Apr 2015 01:08:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Mark Kettenis , jhb@freebsd.org CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Add fbsd_nat_add_target. References: <4032488.W8nPzteMFC@ralph.baldwin.cx> <2013405.YhOVhnvfYq@ralph.baldwin.cx> <201504271954.t3RJsOpO013326@glazunov.sibelius.xs4all.nl> <4869684.VuRe0HgzJ9@ralph.baldwin.cx> <201504272050.t3RKoCSV018211@glazunov.sibelius.xs4all.nl> In-Reply-To: <201504272050.t3RKoCSV018211@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg01023.txt.bz2 On 04/27/2015 09:50 PM, Mark Kettenis wrote: >> From: John Baldwin >> Date: Mon, 27 Apr 2015 16:17:52 -0400 >> FWIW, obsd-nat.c (which I have looked at a bit), also uses a wrapper >> around add_target rather than creating a generic OpenBSD native target. >> To change the FreeBSD native targets I think would be an invasive change >> since they use platform-specific native targets that are pan-BSD as their >> initial target (e.g. amd64bsd_target) and customize from there. To make >> fbsd_nat_target work I would need to rework things like amd64bsd_target >> to modify an existing target instead of returning a new one I think (which >> would also mean changing all the other BSD native targets). > > Which is why I'm perfectly happy with your current 1/3 diff ;). I'm happy with it too. I was just curious. Sounds like we'll need to revisit this if/when we make target_ops a proper class hierarchy, but we'll cross that bridge when we come to it. > As far as I'm concerned you're the expert here and to me the series > looks reasonable as posted. Agreed. Thanks, Pedro Alves