From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63070 invoked by alias); 27 Apr 2015 19:10:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63059 invoked by uid 89); 27 Apr 2015 19:10:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 27 Apr 2015 19:10:21 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3RJAKij004024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 27 Apr 2015 15:10:20 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3RJAIwi029578; Mon, 27 Apr 2015 15:10:19 -0400 Message-ID: <553E899A.9070105@redhat.com> Date: Mon, 27 Apr 2015 19:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: John Baldwin , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Add fbsd_nat_add_target. References: <4032488.W8nPzteMFC@ralph.baldwin.cx> In-Reply-To: <4032488.W8nPzteMFC@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg01013.txt.bz2 On 04/26/2015 02:24 AM, John Baldwin wrote: > Add a wrapper for add_target in fbsd-nat.c to override target operations > common to all native FreeBSD targets. > > gdb/ChangeLog: > > * fbsd-nat.c (fbsd_pid_to_exec_file): Mark static. > (fbsd_find_memory_regions): Mark static. > (fbsd_nat_add_target): New function. > * fbsd-nat.h: Export fbsd_nat_add_target and remove prototypes for > fbsd_pid_to_exec_file and fbsd_find_memory_regions. > * amd64fbsd-nat.c (_initialize_amd64fbsd_nat): Use fbsd_nat_add_target. > * i386fbsd-nat.c (_initialize_i386fbsd_nat): Likewise. > * ppcfbsd-nat.c (_initialize_ppcfbsd_nat): Likewise. > * sparc64fbsd-nat.c (_initialize_sparc64fbsd_nat): Likewise. OOC, any reason you didn't instead do it like: struct target_ops * fbsd_nat_target (void) { struct target_ops *t = inf_ptrace_target (); t->to_pid_to_exec_file = fbsd_pid_to_exec_file; t->to_find_memory_regions = fbsd_find_memory_regions; return t; } and then use fbsd_nat_target instead of inf_ptrace_target directly? This maps a little better to a C++ world. linux-nat.c does it the way you did as it keeps a separate linux_ops target instance around. Thanks, Pedro Alves