From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66835 invoked by alias); 27 Apr 2015 15:59:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66826 invoked by uid 89); 27 Apr 2015 15:59:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 27 Apr 2015 15:59:54 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3RFxqnQ028236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 27 Apr 2015 11:59:52 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3RFxp03008404; Mon, 27 Apr 2015 11:59:52 -0400 Message-ID: <553E5CF7.7090309@redhat.com> Date: Mon, 27 Apr 2015 15:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH] Use exec_file_find to prepend gdb_sysroot in follow_exec References: <1429277318-26646-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1429277318-26646-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00997.txt.bz2 On 04/17/2015 02:28 PM, Gary Benson wrote: > Hi all, > > This commit updates follow_exec to use exec_file_find to prefix > the new executable's filename with gdb_sysroot rather than doing > it longhand. > > Built and regtested on RHEL6.6 x86_64. > > Ok to commit? OK. > - if (gdb_sysroot && *gdb_sysroot) > + if (gdb_sysroot != NULL && *gdb_sysroot != '\0') > { > - char *name = alloca (strlen (gdb_sysroot) > - + strlen (execd_pathname) > - + 1); > + int fd = -1; > + char *name; > > - strcpy (name, gdb_sysroot); > - strcat (name, execd_pathname); > - execd_pathname = name; > + name = exec_file_find (execd_pathname, &fd); > + if (fd >= 0) > + close (fd); We now have at least two places that need to remember to call close. IWBN if we hid that close in a exec_file_find variant, so that callers didn't have to recall to do it. Maybe rename exec_file_find to (e.g.) exec_file_find_fd and reuse the exec_file_find name, even. Thanks, Pedro Alves