From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11399 invoked by alias); 24 Apr 2015 13:51:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11387 invoked by uid 89); 24 Apr 2015 13:51:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 24 Apr 2015 13:51:34 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3ODpW7Z029565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 24 Apr 2015 09:51:32 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3ODpU88031193; Fri, 24 Apr 2015 09:51:31 -0400 Message-ID: <553A4A62.4050201@redhat.com> Date: Fri, 24 Apr 2015 13:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrew Burgess CC: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Add support for dumping to verilog hex format. References: <553821B2.1080704@redhat.com> <20150422230431.GF2422@embecosm.com> <5538CC57.6030305@redhat.com> <20150423213414.GI2422@embecosm.com> In-Reply-To: <20150423213414.GI2422@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00934.txt.bz2 On 04/23/2015 10:34 PM, Andrew Burgess wrote: > * Pedro Alves [2015-04-23 11:41:27 +0100]: > >> Thanks, this looks good to me with the missing _() Eli noticed, and ... > > The _() I wised was a result of copy 'n' pasting some code that > already lacks internationalisation support. This patch fixes those > strings in the immediate area of where I was working. > > This applies on top of the verilog dump patch, and I'll push it as > obvious once that patch is merged. Awesome, thanks for doing this. Thanks, Pedro Alves