Re: [PATCH 03/24] Fix gdb.base/interrupt.exp racy fail against gdbserver

Yao Qi
2015-04-23T14:28:17Z

Pedro Alves <palves@redhat.com> writes:

> Fix this by removing $inferior_spawn_id from the set of spawn ids
> expect is watching as soon as we see the "end of file" string out of
> the inferior spawn id, using an indirect spawn id list.
>

Yeah, it is clever to use indirect spawn ids here...

> Tested on x86-64 Fedora 20, native and gdbserver (both target remote
> and extended-remote).
>
> gdb/testsuite/ChangeLog:
> 2015-04-21 Pedro Alves <palves@redhat.com>
>
> * gdb.base/interrupt.exp: Rename saw_eof to saw_end_of_file. Use

The first sentence can be removed, it is in 02/24.

> an indirect spawn id list holding $inferior_spawn_id instead of
> $inferior_spawn_id directly. On "of of file", remove

On "end of file".

> $inferior_spawn_id from the indirect list.

Patch is good to me.

--
Yao (齐尧)