Re: [PATCH 00/24] Remove gdb,noinferiorio from gdbserver boards

Pedro Alves
2015-07-29T11:41:33Z

On 04/21/2015 07:08 PM, Pedro Alves wrote:
> This series finishes what was started here:
>
> https://sourceware.org/ml/gdb-patches/2015-02/msg00655.html
>
> In a nutshell:
>
> - Make a few tests that are currently relying on inferior I/O to not
> do that anymore.
>
> - Convert all the remaining tests that rely on inferior I/O to use
> $inferior_spawn_id.
>
> - Add a gdb_test_stdio helper used by most of the above.
>
> - Unbuffer all tests that rely on stdio, using the same mechanism
> that ended up used in interrupt.exp, in the series in the url
> above.
>
> - Remove gdb,noinferiorio from our gdbserver boards, so the tests run
> (against gdbserver).
>
> Tested on x86_64 Fedora 20, native, native-gdbserver and also against
> remote gdbserver with no pseudo-tty, which requires the unbuffering.
>
> I've pushed this to users/palves/inferior_spawn_id for review and
> testing convenience.
>
> Pedro Alves (24):
> gdb_test_multiple match eof of any spawn_id
> gdb.base/interrupt.exp: Rename saw_eof to saw_end_of_file
> Fix gdb.base/interrupt.exp racy fail against gdbserver
> Don't rely on inferior I/O in gdb.base/siginfo-addr.exp
> Don't rely on inferior I/O in {call-signal-resume, unwindonsignal}.exp
> Don't rely on inferior I/O in gdb.base/restore.exp
> Introduce gdb_test_stdio
> Make gdb.base/sizeof.exp use gdb_test_stdio
> Make gdb.base/call-strs.exp use gdb_test_stdio
> Make gdb.base/catch-gdb-caused-signals.exp use gdb_test_stdio
> Make gdb.base/dprintf.exp use gdb_test_stdio
> Make gdb.base/a2-run.exp use $inferior_spawn_id and gdb_test_stdio
> Make gdb.base/call-ar-st.exp use gdb_test_stdio
> Make gdb.base/call-rt-st.exp use $inferior_spawn_id
> Make gdb.base/ending-run.exp use gdb_test_stdio
> Make gdb.base/shlib-call.exp use gdb_test_stdio
> Make gdb.base/varargs.exp use gdb_test_stdio
> Make gdb.gdb/complaints.exp use '-i $inferior_spawn_id' and
> gdb_test_stdio
> Make gdb.gdb/selftest.exp use '-i $inferior_spawn_id'
> Adjust MI to $inferior_spawn_id
> Make gdb.mi/mi-dprintf.exp use $inferior_spawn_id
> Unbuffer all tests that rely on stdio
> interrupt.exp: Revert back to checking gdb,noinferiorio at the top
> Don't set gdb,noinferiorio on gdbserver boards

I finally pushed this in, after another round of testing.

Thanks,
Pedro Alves