From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99918 invoked by alias); 23 Apr 2015 16:04:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99909 invoked by uid 89); 23 Apr 2015 16:04:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Apr 2015 16:04:13 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id E2625293204; Thu, 23 Apr 2015 16:04:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3NG488E002384; Thu, 23 Apr 2015 12:04:09 -0400 Message-ID: <553917F8.1040909@redhat.com> Date: Thu, 23 Apr 2015 16:04:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH 08/24] Make gdb.base/sizeof.exp use gdb_test_stdio References: <1429639711-16459-1-git-send-email-palves@redhat.com> <1429639711-16459-9-git-send-email-palves@redhat.com> <5539116D.9070905@ericsson.com> <553911DD.8060607@ericsson.com> <55391497.9090504@redhat.com> In-Reply-To: <55391497.9090504@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00898.txt.bz2 On 04/23/2015 04:49 PM, Pedro Alves wrote: > On 04/23/2015 04:38 PM, Antoine Tremblay wrote: > >>> It's not part of the patch but should we replace : >>> >>> # Test depends on printf, which the sparclet stub doesn't support. >>> if { [istarget "sparclet-*-*"] } { >>> return 0 >>> } >>> >>> With :if [target_info exists gdb,noinferiorio] { ? >>> > > Yes, though... TBC, the tests in question already check gdb_skip_stdio_test, so adding a gdb,noinferiorio check would not be necessary. (But yes to the rest.) Thanks, Pedro Alves