From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31802 invoked by alias); 23 Apr 2015 15:38:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31790 invoked by uid 89); 23 Apr 2015 15:38:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 23 Apr 2015 15:38:09 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 4B.40.12456.79AB8355; Thu, 23 Apr 2015 11:25:44 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.210.2; Thu, 23 Apr 2015 11:38:06 -0400 Message-ID: <553911DD.8060607@ericsson.com> Date: Thu, 23 Apr 2015 15:38:00 -0000 From: Antoine Tremblay User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH 08/24] Make gdb.base/sizeof.exp use gdb_test_stdio References: <1429639711-16459-1-git-send-email-palves@redhat.com> <1429639711-16459-9-git-send-email-palves@redhat.com> <5539116D.9070905@ericsson.com> In-Reply-To: <5539116D.9070905@ericsson.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00891.txt.bz2 On 04/23/2015 11:36 AM, Antoine Tremblay wrote: > > > On 04/21/2015 02:08 PM, Pedro Alves wrote: >> gdb/testsuite/ChangeLog: >> 2015-04-21 Pedro Alves >> >> * gdb.base/sizeof.exp (check_sizeof, check_valueof): Use >> gdb_test_stdio. >> --- >> gdb/testsuite/gdb.base/sizeof.exp | 12 ++++++++---- >> 1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/gdb/testsuite/gdb.base/sizeof.exp >> b/gdb/testsuite/gdb.base/sizeof.exp >> index 7fda76e..a237ee3 100644 >> --- a/gdb/testsuite/gdb.base/sizeof.exp >> +++ b/gdb/testsuite/gdb.base/sizeof.exp >> @@ -70,8 +70,10 @@ set sizeof_long_double [get_sizeof "long double" 8] >> proc check_sizeof { type size } { >> global gdb_prompt >> >> - set pat [string_to_regexp "sizeof (${type}) == ${size}"] >> - gdb_test "next" "${pat}\[\r\n\]+\[0-9\].*" "check sizeof \"$type\"" >> + set pat [string_to_regexp "sizeof (${type}) == ${size}\r\n"] >> + gdb_test_stdio "next" "${pat}" \ >> + "\[0-9\].*" \ >> + "check sizeof \"$type\"" >> } >> >> check_sizeof "char" ${sizeof_char} >> @@ -90,8 +92,10 @@ check_sizeof "long double" ${sizeof_long_double} >> proc check_valueof { exp val } { >> global gdb_prompt >> >> - set pat [string_to_regexp "valueof (${exp}) == ${val}"] >> - gdb_test "next" "${pat}\[\r\n\]+\[0-9\].*" "check valueof \"$exp\"" >> + set pat [string_to_regexp "valueof (${exp}) == ${val}\r\n"] >> + gdb_test_stdio "next" "${pat}" \ >> + "\[0-9\].*" \ >> + "check valueof \"$exp\"" >> } >> >> # Check that GDB and the target agree over the sign of a character. >> > > It's not part of the patch but should we replace : > > # Test depends on printf, which the sparclet stub doesn't support. > if { [istarget "sparclet-*-*"] } { > return 0 > } > > With :if [target_info exists gdb,noinferiorio] { ? > > This is present in other tests too... > > Thanks, > Antoine > > > And add that option to the sparclet target ? ( I could not find that > target in the tree even if config/m32r-stub.exp references it... > Oops I've hit send by mistake this was meant for [PATCH 09/24] Make gdb.base/call-strs.exp use gdb_test_stdio and others like it... Sorry about that Antoine