From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49978 invoked by alias); 23 Apr 2015 14:58:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49966 invoked by uid 89); 23 Apr 2015 14:58:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Apr 2015 14:58:23 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3NEwLiP030583 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Apr 2015 10:58:21 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3NEwJdl011605; Thu, 23 Apr 2015 10:58:20 -0400 Message-ID: <5539088B.7070501@redhat.com> Date: Thu, 23 Apr 2015 14:58:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 03/24] Fix gdb.base/interrupt.exp racy fail against gdbserver References: <1429639711-16459-1-git-send-email-palves@redhat.com> <1429639711-16459-4-git-send-email-palves@redhat.com> <86pp6uyl52.fsf@gmail.com> In-Reply-To: <86pp6uyl52.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00885.txt.bz2 On 04/23/2015 03:28 PM, Yao Qi wrote: > Pedro Alves writes: > >> Fix this by removing $inferior_spawn_id from the set of spawn ids >> expect is watching as soon as we see the "end of file" string out of >> the inferior spawn id, using an indirect spawn id list. >> > > Yeah, it is clever to use indirect spawn ids here... > >> Tested on x86-64 Fedora 20, native and gdbserver (both target remote >> and extended-remote). >> >> gdb/testsuite/ChangeLog: >> 2015-04-21 Pedro Alves >> >> * gdb.base/interrupt.exp: Rename saw_eof to saw_end_of_file. Use > > The first sentence can be removed, it is in 02/24. > >> an indirect spawn id list holding $inferior_spawn_id instead of >> $inferior_spawn_id directly. On "of of file", remove > > On "end of file". > >> $inferior_spawn_id from the indirect list. > > Patch is good to me. Thanks Yao, I fixed ChangeLog and went ahead and pushed in patches 1-3, in order to plug the race in the buildbots. Thanks, Pedro Alves