From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35315 invoked by alias); 23 Apr 2015 11:59:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35300 invoked by uid 89); 23 Apr 2015 11:59:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Apr 2015 11:59:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3NBxfDn001235 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 23 Apr 2015 07:59:41 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3NBxdTc010575; Thu, 23 Apr 2015 07:59:40 -0400 Message-ID: <5538DEAB.1090507@redhat.com> Date: Thu, 23 Apr 2015 11:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jan Kratochvil , Phil Muldoon CC: gdb-patches@sourceware.org Subject: Re: [PATCH] compile: Use libcc1.so->libcc1.so.0 References: <20150421213616.14023.38329.stgit@host1.jankratochvil.net> <55380F04.9050909@redhat.com> <20150423052909.GA18986@host1.jankratochvil.net> <5538CF08.60801@redhat.com> <20150423114745.GA5268@host1.jankratochvil.net> In-Reply-To: <20150423114745.GA5268@host1.jankratochvil.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00870.txt.bz2 On 04/23/2015 12:47 PM, Jan Kratochvil wrote: > On Thu, 23 Apr 2015 12:52:56 +0200, Phil Muldoon wrote: >> On 23/04/15 06:29, Jan Kratochvil wrote: >>> >>> So you request forward/backward compatibilities, specifically: >>> >>> (1) Do you request future gdb-7.10 is compatible with existing gcc-5.x? >>> >>> (2) Do you request future gcc-6.0 is compatible with existing gdb-7.9? >>> >>> With an answer for (1) and (2) we can decide on how to implement it. >> >> Both! ;) > > While (1) could be possibly useful personally I do not find > the compatibility (2) useful. > > >> I don't think a version change merits that. And the change is tiny: >> just one more parameter for a function. You could avoid it by having >> two public methods exported in the vtable: foo (old params), foo (old >> params, new params) and then re-factoring out the old function to >> foo_worker_1 and have the two "foo" functions call foo_worker_1 with >> the new parameter or NULL in its place. > > I do not see so clear how to implement it. > > If GDB changes: > gdb/compile/compile-c-support.c:110: context = (*func) (GCC_FE_VERSION_0, GCC_C_FE_VERSION_0); > -> > gdb/compile/compile-c-support.c:110: context = (*func) (GCC_FE_VERSION_1, GCC_C_FE_VERSION_0); > then compatibiity (1) is violated. Besides that you said no new API version > should be introduced. Here's what I suggest. I'm not sure whether it should be GCC_FE_VERSION_0 or GCC_C_FE_VERSION_0 that should be bumped in this case, but, assuming the former, you'd solve this by first making (and documenting) the vtable of v1 compatible with v0. Then have gdb do: context = (*func) (GCC_FE_VERSION_1, GCC_C_FE_VERSION_0); if (context == NULL) context = (*func) (GCC_FE_VERSION_0, GCC_C_FE_VERSION_0); For as long as gdb supports both v1 and v0, places that call the v1-only functions must check that they're talking to a v1 context before calling through the function pointer, of course. On the plugin side do something like: if (version == 0 || version == 1) { // v1 is compatible with v0, and we're supporting v0 for a while. context->version = version; return context; } else { // error. } Thanks, Pedro Alves