From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27775 invoked by alias); 23 Apr 2015 10:41:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27753 invoked by uid 89); 23 Apr 2015 10:41:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Apr 2015 10:41:32 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3NAfTCt027462 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Apr 2015 06:41:30 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3NAfRC0002669; Thu, 23 Apr 2015 06:41:28 -0400 Message-ID: <5538CC57.6030305@redhat.com> Date: Thu, 23 Apr 2015 10:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrew Burgess CC: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Add support for dumping to verilog hex format. References: <553821B2.1080704@redhat.com> <20150422230431.GF2422@embecosm.com> In-Reply-To: <20150422230431.GF2422@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00861.txt.bz2 On 04/23/2015 12:04 AM, Andrew Burgess wrote: > * Pedro Alves [2015-04-22 23:33:22 +0100]: > >> On 04/22/2015 11:24 PM, Andrew Burgess wrote: >>> This patch extends the 'dump' command to generate output in the >>> verilog hex format supported by bfd. >>> >>> OK to apply? >> >> Sounds like gdb.base/dump.exp should be extended to cover this? > > Of course, sorry. > > New version, including tests. Given that bfd (currently) only > supports writing to verilog format, and not reading, then the tests > (obviously) only cover 'dump' and not 'restore'. > > Within dump.exp I reordered the 'all_files' list a little in order to > make it easier to insert new files. Everything else should be > straight forward. (Looks like the test could be simplified with something like foreach format $dump_formats {} { ... }. Something for another day.) Thanks, this looks good to me with the missing _() Eli noticed, and ... > index 0410702..4b78fb4 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -10890,6 +10890,8 @@ Intel hex format. > Motorola S-record format. > @item tekhex > Tektronix Hex format. > +@item verilog > +Verilog Hex format. > @end table > > @value{GDBN} uses the same definitions of these formats as the ... at least this bit needs updating too: You can use the commands @code{dump}, @code{append}, and @code{restore} to copy data between target memory and a file. The @code{dump} and @code{append} commands write data to a file, and the @code{restore} command reads data from a file back into the inferior's memory. Files may be in binary, Motorola S-record, Intel hex, or Tektronix Hex format; however, @value{GDBN} can only append to binary files. Thanks, Pedro Alves