From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17620 invoked by alias); 22 Apr 2015 22:19:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17603 invoked by uid 89); 22 Apr 2015 22:19:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 22 Apr 2015 22:19:21 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id F369B8F31D; Wed, 22 Apr 2015 22:19:19 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3MMJIEx012788; Wed, 22 Apr 2015 18:19:19 -0400 Message-ID: <55381E66.3040702@redhat.com> Date: Wed, 22 Apr 2015 22:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Doug Evans CC: gdb-patches@sourceware.org Subject: Re: [PATCH v3 05/17] Embed the pending step-over chain in thread_info objects References: <1429267521-21047-1-git-send-email-palves@redhat.com> <1429267521-21047-6-git-send-email-palves@redhat.com> <21815.8859.290139.116294@ruffy2.mtv.corp.google.com> In-Reply-To: <21815.8859.290139.116294@ruffy2.mtv.corp.google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00850.txt.bz2 On 04/22/2015 05:24 AM, Doug Evans wrote: > > --- a/gdb/infrun.c > > +++ b/gdb/infrun.c > >... > > @@ -1855,24 +1842,44 @@ displaced_step_fixup (ptid_t event_ptid, enum gdb_signal signal) > > do_cleanups (old_cleanups); > > > > displaced->step_ptid = null_ptid; > > +} > > > > - /* Are there any pending displaced stepping requests? If so, run > > - one now. Leave the state object around, since we're likely to > > - need it again soon. */ > > - while (displaced->step_request_queue) > > +/* Are there any pending step-over requests? If so, run one now. */ > > Hi. > > Nit: IIUC "run one now" should read "run all we can now". Thanks, I did that change. -- Pedro Alves