Re: [PATCH] Find debug symbols file by buildid for coff file format also

Eli Zaretskii
2015-03-16T16:30:45Z

> From: Jon TURNEY <jon.turney@dronecode.org.uk>
> Cc: Jon TURNEY <jon.turney@dronecode.org.uk>
> Date: Mon, 16 Mar 2015 15:37:10 +0000
>
> bfd/ChangeLog:
>
> 2015-03-14 Jon TURNEY <jon.turney@dronecode.org.uk>
>
> * elf-bfd.h : Remove struct elf_build_id.
> * bfd.c : Add struct bfd_build_id.
> * bfd-in2.h: Regenerate.
> * elf.c (elfobj_grok_gnu_build_id): Update to use bfd_build_id.
> * libpei.h: Add protoype and macros for
> bfd_XXi_slurp_codeview_record.
> * peXXigen.c (_bfd_XXi_slurp_codeview_record): Make public
> * peicode.h (pe_bfd_read_buildid): Add.
> (pe_bfd_object_p): Use pe_bfd_read_buildid().
>
> gdb/ChangeLog:
>
> 2015-03-14 Jon TURNEY <jon.turney@dronecode.org.uk>
>
> * build-id.c (build_id_bfd_get): Use bfd_build_id.
> (build_id_verify): Ditto.
> * build-id.h: Ditto.
> (find_separate_debug_file_by_buildid): Ditto.
> * python/py-objfile.c (objfpy_get_build_id)
> (objfpy_build_id_matches, objfpy_lookup_objfile_by_build_id): Ditto.
> * coffread.c (coff_symfile_read): Try
> find_separate_debug_file_by_buildid.
>
> gdb/doc/ChangeLog:
>
> 2015-03-14 Jon TURNEY <jon.turney@dronecode.org.uk>
>
> * gdb.texinfo (Separate Debug Files): Document that COFF is also
> supported.

The gdb.texinfo part is OK, except that AFAIK PE is not the same as
COFF, so I suggest to amend the ChangeLog entry above.

Thanks.