Re: [PATCH] Allow gdb to find debug symbols file by build-id for PE file format also

Mike Frysinger
2015-06-15T16:34:37Z

[-- Attachment #1: Type: text/plain, Size: 909 bytes --]

On 10 Jun 2015 15:25, Jon Turney wrote:
> --- a/bfd/bfd-in2.h
> +++ b/bfd/bfd-in2.h
> @@ -6322,6 +6322,12 @@ enum bfd_plugin_format
> bfd_plugin_no = 2
> };
>
> +struct bfd_build_id
> + {
> + size_t size;
> + bfd_byte data[1];
> + };

the use of size_t here breaks a number of targets because this header doesn't
include the header which provides the definition for it. it happens to work for
some due to other files pulling in the right headers, but it's still broken. i
don't know what the policy is here in this header as it seems to isolate itself
from the OS quite a bit.

In file included from ../../../../sim/erc32/../../include/gdb/callback.h:55:0,
from ../../../../sim/erc32/sis.h:18,
from ../../../../sim/erc32/exec.c:20:
../../bfd/bfd.h:6332:5: error: unknown type name ‘size_t’
size_t size;
^
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]