Re: [PATCH v3 5/5] Eliminate make_cleanup_ui_file_delete / make ui_file a class hierarchy

Pedro Alves
2017-02-01T00:31:45Z

On 01/25/2017 07:47 PM, Pedro Alves wrote:
> On 01/25/2017 07:31 PM, Pedro Alves wrote:
>
>> Here's the diff to the incoming v3. I think this addresses all
>> your comments. The only other change is that I realized that
>> ui_file should be abstract, so that people don't try to allocate
>> one to build a "/dev/null" stream. I've checked the AIX build
>> on gcc119. I'll send v3 shortly.
>
> Here it is. I've pushed it to users/palves/ui_file_v3 too,
> along with the (not posted) "move tee down" follow up patch
> I mentioned.

Today I rebased this on master, and that had conflicts with the
gdb_disassembler wrapper series. Getting rid of the ui_file_rewind
calls in disasm.c required redoing a part of the gdb_disassembler
changes to disasm.c. I think the result looks even better in the end.
I've pushed in the small precursor patches to master, and posted
a v4. Let me know what you think of it.

Thanks,
Pedro Alves