From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93594 invoked by alias); 17 Apr 2015 16:21:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93536 invoked by uid 89); 17 Apr 2015 16:21:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Apr 2015 16:21:50 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3HGLiIM019250 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Apr 2015 12:21:44 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3HGLfdE028969; Fri, 17 Apr 2015 12:21:42 -0400 Message-ID: <55313315.1010203@redhat.com> Date: Fri, 17 Apr 2015 16:21:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Max Filippov , gdb-patches@sourceware.org CC: Maxim Grigoriev , Woody LaRue , Marc Gauthier , linux-xtensa@linux-xtensa.org Subject: Re: [PATCH] gdb: fix xtensa build with custom overlay References: <1429287116-20216-1-git-send-email-jcmvbkbc@gmail.com> In-Reply-To: <1429287116-20216-1-git-send-email-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00693.txt.bz2 On 04/17/2015 05:11 PM, Max Filippov wrote: > The commit 14e361d7aa3bbd8601b0457ee8558344e444c651 ("xtensa-config.c: > missing defs.h include") fixed the build of default xtensa configuration > by including defs.h in the beginning of xtensa-config.c. Unfortunately > this fix doesn't work when gdb is configured for another xtensa core, as > the file xtensa-config.c is a part of configuration overlay and it gets > overwritten. To fix the build for all existing configurations include > defs.h into gdb/xtensa-tdep.h, where the issue (reference to undeclared > uint32_t) actually is. Hmm, I think that's news to me. Can you please expand a bit on why is this mechanism necessary? In any case, that mechanism must already by outputting: #include "xtensa-config.h" #include "xtensa-tdep.h" Just make it output #include "defs.h" as well? That .c files must include defs.h is part of the standards: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards " (...) All other .c files under gdb/ must include defs.h as their first non-comment line. (...) No .h file should include defs.h, server.h or common-defs.h. (...) " > > 2015-04-17 Max Filippov > gdb/ > * xtensa-tdep.h: Include defs.h Note missing period. Thanks, Pedro Alves