From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9146 invoked by alias); 17 Apr 2015 11:01:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9131 invoked by uid 89); 17 Apr 2015 11:01:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Apr 2015 11:01:44 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3HB1hLf030525 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 17 Apr 2015 07:01:43 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3HB1fU2016590 for ; Fri, 17 Apr 2015 07:01:42 -0400 Message-ID: <5530E815.1080907@redhat.com> Date: Fri, 17 Apr 2015 11:01:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH v3 09/17] Teach non-stop to do in-line step-overs (stop all, step, restart) References: <1429267521-21047-1-git-send-email-palves@redhat.com> <1429267521-21047-10-git-send-email-palves@redhat.com> In-Reply-To: <1429267521-21047-10-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00666.txt.bz2 On 04/17/2015 11:45 AM, Pedro Alves wrote: > make non-stop work for all (albeit, not as efficiently). And then > there are scenarios where even if the architecture supports displaced > stepping, we can't use it, because we e.g., don't find a usable > address to use as displaced step scratch pad. It should also fix > stepping past watchpoints on targets that have non-continuable > watchpoints in non-stop mode (e.g., PPC, untested). Reading back, I notice that wrote that "should fix" and "untested" back before v1, and forgot to update it since. This definitely fixes that scenario. Since: https://sourceware.org/ml/gdb-patches/2015-04/msg00384.html PPC64: Fix step-over-trips-on-watchpoint.exp with displaced stepping on GDB now does not start a displaced step if it need to step over a watchpoint, instead if steps the instruction at the original address. What was missing was pausing all threads in order to be able to remove the watchpoint without other threads missing it -- that's what's fixed by this patch. > Running the > instruction out of line in the displaced stepping scratch pad doesn't > help that case, as the copied instruction reads/writes the same > watched memory... We can fix that too by teaching GDB to only remove > the watchpoint from the thread that we want to move past the > watchpoint (currently, removing a watchpoint always removes it from > all threads), but again, that can be considered an optimization; not > all targets would support it. I'll update the commit log before pushing. Thanks, Pedro Alves