From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30307 invoked by alias); 15 Apr 2015 16:13:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30297 invoked by uid 89); 15 Apr 2015 16:13:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 15 Apr 2015 16:13:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 38B008E6E5; Wed, 15 Apr 2015 16:13:42 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3FGDeAR018260; Wed, 15 Apr 2015 12:13:41 -0400 Message-ID: <552E8E34.4030006@redhat.com> Date: Wed, 15 Apr 2015 16:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [PATCH 7/7] Access executable from remote system when first inferior appears References: <1427887341-31819-1-git-send-email-gbenson@redhat.com> <1427887341-31819-8-git-send-email-gbenson@redhat.com> <552E3C6B.2090300@redhat.com> <20150415135555.GA18079@blade.nx> In-Reply-To: <20150415135555.GA18079@blade.nx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00583.txt.bz2 On 04/15/2015 02:55 PM, Gary Benson wrote: > Pedro Alves wrote: >> > On 04/01/2015 12:22 PM, Gary Benson wrote: >>> > > This commit modifies remote_add_inferior to take an extra argument >>> > > try_open_exec. If this is nonzero, remote_add_inferior will >>> > > attempt to open this inferior's executable as the main executable >>> > > if no main executable is open already. Callers are updated >>> > > appropriately. >>> > > >>> > > One testcase required updating as a result of this commit. The >>> > > test checked that GDB's "info files" command does not crash if no >>> > > main executable is open, and relied on GDB's inability to access >>> > > the main executable over the remote protocol. The test was >>> > > updated to inhibit this new behavior. >> > >> > So this is significant user-visible change too. I think it deserves >> > an example in the commit log, and a NEWS entry. The manual should >> > probably be updated to explain/mention this too. We already mention >> > something like this in the "attach" docs: >> > >> > "When you use @code{attach}, the debugger finds the program running in >> > the process first (...)" > How about these? > Missed the manual bit: > > ** gdb.Objfile objects have a new attribute "username", > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 964f9c4..4f9c21b 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -2531,7 +2531,8 @@ programs on bare-board targets that lack an operating system. You must > also have permission to send the process a signal. > > When you use @code{attach}, the debugger finds the program running in > -the process first by looking in the current working directory, then (if > +the process first by querying the operating system. If this fails, > +@value{GDBN} looks first in the current working directory, then (if > the program is not found) by using the source file search path > (@pxref{Source Path, ,Specifying Source Directories}). You can also use > the @code{file} command to load the program. @xref{Files, ,Commands to This looks right, but it's not what I was thinking. The "attach" reference was just to give an example of where we document that gdb find the program for the user. I think we should say something like that in the "target remote" documentation too. Thanks, Pedro Alves