Re: [PATCH 5/7] Implement remote_pid_to_exec_file using qXfer:exec-file:read

Doug Evans
2015-04-08T01:57:44Z

On Tue, Apr 7, 2015 at 2:08 AM, Gary Benson <gbenson@redhat.com> wrote:
> Eli Zaretskii wrote:
>> > From: Doug Evans <xdje42@gmail.com>
>> > Cc: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
>> > Date: Mon, 06 Apr 2015 10:00:08 -0700
>> >
>> > Eli Zaretskii <eliz@gnu.org> writes:
>> >
>> > > > Date: Wed, 1 Apr 2015 12:22:19 +0100
>> > > >
>> > > > +qXfer:exec-file:read
>> > > > + Return the pathname of the file that was executed to create a
>> > > ^^^^^^^^^^^^^^^^^^^^^^^^
>> > > "the name of the file"
>> > >
>> > > OK with this change.
>> > >
>> > > > +@item qXfer:exec-file:read:@var{annex}:@var{offset},@var{length}
>> > > > +@anchor{qXfer executable filename read}
>> > > > +Return the pathname of the file that was executed to create a process
>> > > ^^^^^^^^^^^^^^^^^^^^^^^^
>> > > Likewise.
>> > >
>> > > Otherwise, the documentation parts are OK.
>> >
>> > "the name of the file" is ambiguous though.
>> > Is it the full path name of the file? Or the base name?
>>
>> I don't know the answers, but if this is a "full path name", then
>> "the full absolute name of the file" will convey that.
>
> It should be absolute. I will use "the full absolute name of the
> file" as Eli suggests.

Is the "full" in "full absolute name" redundant?