From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12762 invoked by alias); 15 Apr 2015 10:47:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12749 invoked by uid 89); 15 Apr 2015 10:47:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 15 Apr 2015 10:47:21 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3FAlJVH009347 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 15 Apr 2015 06:47:19 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3FAlIJP014485; Wed, 15 Apr 2015 06:47:19 -0400 Message-ID: <552E41B5.1000508@redhat.com> Date: Wed, 15 Apr 2015 10:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Do not require "file" commands for remote targets References: <1427887341-31819-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1427887341-31819-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00554.txt.bz2 On 04/01/2015 12:22 PM, Gary Benson wrote: > Hi all, > > This series builds on my 'New default sysroot "target:"' series [1] > and makes GDB able to locate and access executable files when using > remote targets. This removes the need for a "file" command before > "target *remote ...". > > Patches 1-3 cause the main executable's pathname to be prefixed with > gdb_sysroot on attach in much the same way pathnames of shared > libraries are treated. > > Patches 4-6 implement the to_pid_to_exec_file method for remote > targets. This removes the need for the "file" command when using > the "attach" command with gdbserver with multiprocess extensions: > > bash$ gdb -q > (gdb) target extended-remote | gdbserver --multi - > Remote debugging using | gdbserver --multi - > Remote debugging using stdio > (gdb) attach 31979 > Attaching to process 31979 > Attached; pid = 31979 > Reading symbols from target:/bin/bash... > > Patch 7 causes GDB to attempt to locate and open the executable > in remote-target cases without multiprocess extensions: Should be "with multiprocess extensions". Without those, we don't know the target's pid, and thus can't use pid-to-exec-file. > > bash$ gdb -q > (gdb) target remote | gdbserver - --attach 31979 > Remote debugging using | gdbserver - --attach 31979 > Attached; pid = 31979 > Remote debugging using stdio > Reading symbols from target:/bin/bash... > > and: > > bash$ gdb -q > (gdb) target remote | gdbserver - /bin/sh > Remote debugging using | gdbserver - /bin/sh > Process /bin/sh created; pid = 32166 > stdin/stdout redirected > Remote debugging using stdio > Reading symbols from target:/bin/bash... > > There is no change to GDB's behaviour if the user has specified a > main executable, with the "file" command or on startup, so existing > use cases do not change. > > Built and regtested on RHEL 6.6 x86_64. > > Ok to commit? I commented on a couple things, but overall this looks good to me. Thanks, Pedro Alves