From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29337 invoked by alias); 15 Apr 2015 08:56:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29287 invoked by uid 89); 15 Apr 2015 08:56:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 15 Apr 2015 08:56:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 286CAAB111; Wed, 15 Apr 2015 08:56:53 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3F8uoLw024211; Wed, 15 Apr 2015 04:56:51 -0400 Message-ID: <552E27D2.9020808@redhat.com> Date: Wed, 15 Apr 2015 08:56:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Doug Evans , Gary Benson CC: gdb-patches Subject: Re: [PATCH] Mark object files with "target:" filenames as OBJF_NONLOCAL_FILENAME References: <1428952063-2121-1-git-send-email-gbenson@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00548.txt.bz2 On 04/14/2015 12:27 AM, Doug Evans wrote: > While I'm all for building on "foo:bar" in path names > (target:foo, remote:foo, and so on), IWBN to build a library on top of that > rather than have sideband tables that recorded such extra info. > [Down the road I can imagine having a class for such things such that > we could augment what's recorded beyond just a "foo:bar" string, but > that's later, if ever.] I agree. I like that -- I can definitely see us with something like a "struct gdb_path" object rather than a passing around a bare char * / string. > > IOW, how about having an "is non-local" predicate that is invoked on > the path whenever needed? > [it could be the current "is_target_filename" or if you wanted to add > a layer of abstraction that might be ok, depending on how this might > evolve] I agree, for now is_target_filename seems good. > > I realize this is a bit incongruous with OBJF_NOT_FILENAME, but I'd > rather head in the above direction than adding more OBJF_ flags. *nod* Thanks, Pedro Alves