From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112208 invoked by alias); 13 Apr 2015 21:54:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112199 invoked by uid 89); 13 Apr 2015 21:54:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Apr 2015 21:53:59 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 581878E3EC for ; Mon, 13 Apr 2015 21:53:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3DLrule011300; Mon, 13 Apr 2015 17:53:57 -0400 Message-ID: <552C3AF4.4000604@redhat.com> Date: Mon, 13 Apr 2015 21:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH] Zero supplied stat buffers in functions that pretend to stat References: <1428961250-23031-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1428961250-23031-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00505.txt.bz2 On 04/13/2015 10:40 PM, Gary Benson wrote: > Hi all, > > GDB has five places where it pretends to stat for bfd_openr_iovec. > Four of these only set the incoming buffer's st_size, leaving the > other fields unchanged, which is to say very likely populated with > random values from the stack. remote_bfd_iovec_stat was fixed in > 0a93529c56714b1da3d7106d3e0300764f8bb81c; this commit fixes the > other four. > > Built and and regtested on RHEL6.6 x86_64. > > Ok to commit? Eh, how apropos for the bfd cache discussion. OK, thanks. -- Pedro Alves