From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41021 invoked by alias); 10 Apr 2015 10:05:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41012 invoked by uid 89); 10 Apr 2015 10:05:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 10 Apr 2015 10:05:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3AA4veD012632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Apr 2015 06:04:58 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3AA4tcD005890; Fri, 10 Apr 2015 06:04:56 -0400 Message-ID: <5527A047.1030201@redhat.com> Date: Fri, 10 Apr 2015 10:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Luis Gustavo , "'gdb-patches@sourceware.org'" Subject: Re: [PATCH] Harden gdb.base/bp-permanent.exp References: <5526B296.8040000@codesourcery.com> In-Reply-To: <5526B296.8040000@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00372.txt.bz2 On 04/09/2015 06:10 PM, Luis Machado wrote: > diff --git a/gdb/testsuite/gdb.base/bp-permanent.exp b/gdb/testsuite/gdb.base/bp-permanent.exp > index 81a5293..9193db8 100644 > --- a/gdb/testsuite/gdb.base/bp-permanent.exp > +++ b/gdb/testsuite/gdb.base/bp-permanent.exp > @@ -104,7 +104,18 @@ proc test {always_inserted sw_watchpoint} { > # to memory manually. > set count [expr $address_after_bp - $address_bp] > for {set i 0} {$i < $count} {incr i} { > - gdb_test "p /x addr_bp\[$i\] = buffer\[$i\]" " = .*" > + gdb_test_multiple "p /x addr_bp\[$i\] = buffer\[$i\]" $test { > + -re "Cannot access memory at address $hex.*$gdb_prompt $" { > + # Some targets (QEMU for one) do not allow writes to the > + # .text section. It is no use continuing with the test > + # at this point. Just return. Double space after period. > + unsupported $test Something like: unsupported "Cannot access memory" OK with those changes. I'm thinking it'd be good to adjust the test to hardcode the breakpoint instruction (on an arch by arch basis, leaving the current generic code in place), as it'd be good to test stepping past permanent/program trap instructions on QEMU/Valgrind, etc. too. Thanks, Pedro Alves