From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50878 invoked by alias); 9 Apr 2015 09:30:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50662 invoked by uid 89); 9 Apr 2015 09:30:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Apr 2015 09:30:11 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id BF9508E66F; Thu, 9 Apr 2015 09:30:09 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t399U7UG020957; Thu, 9 Apr 2015 05:30:08 -0400 Message-ID: <5526469F.5050903@redhat.com> Date: Thu, 09 Apr 2015 09:30:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Import strtok_r gnulib module References: <1428513587-8471-1-git-send-email-palves@redhat.com> <1428513587-8471-3-git-send-email-palves@redhat.com> <863849wttw.fsf@gmail.com> In-Reply-To: <863849wttw.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00322.txt.bz2 On 04/09/2015 10:10 AM, Yao Qi wrote: >> > * gnulib/Makefile.in (aclocal_m4_deps): Add import/m4/strtok_r.m4. > Nit: gnulib/Makefile.in is regenerated, isn't? If so, "Regenerate" > should be used too. > Nope, that list is maintained manually. And it looks very much out of sync with the m4 files in the m4/ dir already, though I didn't fix that in this patch. Thanks, Pedro Alves