From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38911 invoked by alias); 9 Apr 2015 09:04:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38877 invoked by uid 89); 9 Apr 2015 09:04:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Apr 2015 09:04:43 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 057B08E67C; Thu, 9 Apr 2015 09:04:42 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3994eMj006917; Thu, 9 Apr 2015 05:04:41 -0400 Message-ID: <552640A8.1050504@redhat.com> Date: Thu, 09 Apr 2015 09:04:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] gdbserver gnu/linux: stepping over breakpoint References: <1428569112-18004-1-git-send-email-qiyaoltc@gmail.com> In-Reply-To: <1428569112-18004-1-git-send-email-qiyaoltc@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00317.txt.bz2 On 04/09/2015 09:45 AM, Yao Qi wrote: > gdb/gdbserver: > > 2015-04-09 Yao Qi > > * linux-low.c (linux_insert_point): Call > insert_memory_breakpoint if TYPE is raw_bkpt_type_sw. > (linux_remove_point): Call remove_memory_breakpoint if type is > raw_bkpt_type_sw. > * linux-x86-low.c (x86_insert_point): Don't call > insert_memory_breakpoint. > (x86_remove_point): Don't call remove_memory_breakpoint. LGTM. Thanks, Pedro Alves