Re: [PATCH v2 15/23] Implement all-stop on top of a target running non-stop mode

Yao Qi
2015-04-08T09:34:51Z

Pedro Alves <palves@redhat.com> writes:

> @@ -1997,7 +1998,7 @@ start_step_over_inferior (struct inferior *inf)
> {
> /* In all-stop, we shouldn't have resumed unless we needed a
> step over. */
> - gdb_assert (non_stop);
> + gdb_assert (target_is_non_stop_p ());
> }
> }

Hi Pedro,
I tested the whole series on arm-linux and there is an assert triggered
with gdbserver,

signal SIGTRAP^M
Continuing with signal SIGTRAP.^M
../../../binutils-gdb/gdb/infrun.c:2008: internal-error: start_step_over_inferior: Assertion `target_is_non_stop_p ()' failed.^M
A problem internal to GDB has been detected,^M
further debugging may prove unreliable.^M
Quit this debugging session? (y or n) FAIL: gdb.threads/signal-sigtrap.exp: sigtrap thread 2: signal SIGTRAP reaches handler (GDB internal error)

there is no such internal error in native testing. I haven't analyse it
carefully yet.

--
Yao (齐尧)