From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67361 invoked by alias); 8 Apr 2015 15:06:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67346 invoked by uid 89); 8 Apr 2015 15:06:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f53.google.com Received: from mail-pa0-f53.google.com (HELO mail-pa0-f53.google.com) (209.85.220.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 08 Apr 2015 15:06:52 +0000 Received: by pabtp1 with SMTP id tp1so11758891pab.2 for ; Wed, 08 Apr 2015 08:06:50 -0700 (PDT) X-Received: by 10.70.102.38 with SMTP id fl6mr47727252pdb.154.1428505610309; Wed, 08 Apr 2015 08:06:50 -0700 (PDT) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id gy1sm11359861pbc.55.2015.04.08.08.06.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Apr 2015 08:06:49 -0700 (PDT) Message-ID: <55254405.9000404@gmail.com> Date: Wed, 08 Apr 2015 15:06:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Ulrich Weigand , Pedro Alves CC: Peter Schauer , gdb-patches@sourceware.org Subject: Re: [rfc, spu] Don't call set_gdbarch_cannot_step_breakpoint in spu_gdbarch_init References: <201504071245.t37CjfGk007933@d06av02.portsmouth.uk.ibm.com> In-Reply-To: <201504071245.t37CjfGk007933@d06av02.portsmouth.uk.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00268.txt.bz2 On 07/04/15 13:45, Ulrich Weigand wrote: > It's been set since spu-tdep.c was committed upstream, and in > fact it's set in every single version in our internal repositories > of the code before it went upstream, too. (Going back over 10 years.) > > But I don't know why it was added either, since SPU has been using > software single-step forever too, and even the very first version of > GDB we patched to support SPU would ignore cannot_step_breakpoint > for software single-step architectures ... > > So I'd say just go ahead and remove it. Patch is pushed in. -- Yao (齐尧)