From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57843 invoked by alias); 7 Apr 2015 17:31:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57834 invoked by uid 89); 7 Apr 2015 17:31:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 07 Apr 2015 17:31:14 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t37HVBjn019894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 7 Apr 2015 13:31:13 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t37HVAA4020963 for ; Tue, 7 Apr 2015 13:31:10 -0400 Message-ID: <5524145D.8010103@redhat.com> Date: Tue, 07 Apr 2015 17:31:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH 0/6] Introduce $inferior_spawn_id, make interrupt.exp work with GDBserver References: <1424699660-11727-1-git-send-email-palves@redhat.com> In-Reply-To: <1424699660-11727-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00238.txt.bz2 On 02/23/2015 01:54 PM, Pedro Alves wrote: > After fixing a gdbserver syscall restart issue, I thought of adding a > new test to exercise syscall restarting. Then I recalled that we > already have interrupt.exp for that. However, that test is skipped on > gdbserver, because it relies on inferior i/o. > > When testing with gdbserver, inferior are spawned by gdbserver, on > gdbserver's pty, and so gdb_test_multiple/gdb_expect, don't see the > inferior's i/o. > > This series introduces a mechanism that allows tests to match inferior > i/o separately from gdb i/o, like: > > send_inferior "echo me\n" > gdb_test_multiple "continue" "test msg" { > -i "$inferior_spawn_id" -re "echo me\r\necho\r\n" { > ... > } > -i "$gdb_spawn_id" -re "error.*$gdb_prompt $" { > ... > } > } > > and then adjusts interrupt.exp to use the new mechanism. > > I took the idea from Don Breazeal's use of $server_spawn_id here > , and > generalized it. > > A couple bugs had to be fixed along the way, and I took the change to > clean up interrupt.exp to use gdb_test_multiple instead of gdb_expect > too. interrupt.exp now passes against gdbserver here, on x86_64 > Fedora 20 (It fails with gdbserver/-m32 testing in the exact same way > it fails on native/-m32 testing, due to a kernel bug). > I've now pushed this series in. Thanks, Pedro Alves