Re: [python][patch] Python rbreak

Phil Muldoon
2017-10-11T12:27:06Z

On 11/10/17 13:11, Eli Zaretskii wrote:
>> From: Phil Muldoon <pmuldoon@redhat.com>
>> Date: Wed, 11 Oct 2017 12:30:17 +0100
>>
>> 2017-10-11 Phil Muldoon <pmuldoon@redhat.com>
>>
>> * python.texi (Basic Python): Add rbreak documentation.
>
> This should go into a separate gdb/doc/ChangeLog file.

It is locally. Not sure why the relative paths were not
included. Anyway, noted and it will be in the doc/ ChangeLog.

>
>> +@findex gdb.rbreak
>> +@defun gdb.rbreak (regex @r{[}, minisyms @r{[}, throttle, @r{[}, symtabs @r{]]]})
>
> You don't need that @findex, since @defun automatically inserts the
> function into the function index.

Thanks.

> The documentation part is okay with this fixed, but I think we also
> want a NEWS entry.

I'll add a NEWS entry and repost the doc part of the patch.

Cheers

Phil