Re: [RFA/RFC] Clarify contents of NEWS entry re: Python "rbreak" (waa: "Re: [python][patch] Python rbreak")

Phil Muldoon
2018-02-01T10:26:23Z

On 01/02/18 09:45, Joel Brobecker wrote:
> [hi Eli -- not sure if the attached patch is obvious or not, so I will
> wait for your approval, assuming Phil confirms. Thank you!]
>
> Hi Phil,
>
> Can you clarify something for me?
>
>>> diff --git a/gdb/NEWS b/gdb/NEWS
>>> index 2bad096a86..1d26ea4af7 100644
>>> --- a/gdb/NEWS
>>> +++ b/gdb/NEWS
>>> @@ -24,6 +24,10 @@
>>> gdb.new_thread are emitted. See the manual for further
>>> description of these.
>>>
>>> + ** A new command, "rbreak" has been added to the Python API. This
>>> + command allows the setting of a large number of breakpoints via a
>>> + regex pattern in Python. See the manual for further details.
>
> Based on the implementation, I'm pretty sure that it's actualy a new
> function, rather than a new command; is that correct?
>
> If I am, I would like to suggest the following change to the NEWS file,
> to make it clearer.

It's a Python implementation of rbreak. I thought about making prbreak
as a Python implementation of a GDB command but decided to leave it as
an API call instead. However you want to word it is totally
fine. Sorry for any confusion introduced!

Cheers

Phil