From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81109 invoked by alias); 13 Oct 2017 08:08:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81089 invoked by uid 89); 13 Oct 2017 08:08:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Oct 2017 08:08:54 +0000 Received: by mail-wm0-f45.google.com with SMTP id t69so19179089wmt.2 for ; Fri, 13 Oct 2017 01:08:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CrTnbqOUGzLfTlqhNSYdlNLeC1ApNndhWwNBfq48IIQ=; b=e6lVWr5TLBPDBY4vORz8E3m/NEz/vhBn0d44knTICg96Sy335DiL/V9r0cqdqmOUP1 OK5B4NBI7LXCb7hJtn0HUJwBqY2sKXr6+ywsCmy/8inhOiduaIsxTPxUbYe/dVUDdJcK ipSAFtsh6kAsxEdcHE0SM9cS+eWC2b2S54d+aj1arZMmOEvVu95XMNJQT6WL7EJnHxyJ qE3KpyvIwq0IbR8tlg7BziGQPda9qZ3BQuy9j0CJyU2X+IpsrHMW1mlgVnRWIiNmhuJA 0xZDO+PqtCSSkrjQSJDlnHgCsmOh6vQoXzyODa5IqlRtL4RhecpxUus0wKr9lU7U3pU+ v4SA== X-Gm-Message-State: AMCzsaVYlg4WET8axC8hG0kdtLJgW3Wn3+4Z4jGbukPsf+IX0+M+SIHg cbNlL5fowUHyMCnN+p9azPeJvNbbUws= X-Google-Smtp-Source: AOwi7QBuLJaWcESFrGQxgd+6y3a+2zsk0qvyeUEBYZ7Eh2/Q/F9GggmnaXgUZTDSNrr+wF2JwGRfZA== X-Received: by 10.28.35.67 with SMTP id j64mr646730wmj.55.1507882131561; Fri, 13 Oct 2017 01:08:51 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4? ([2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id s67sm625319wmd.23.2017.10.13.01.08.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Oct 2017 01:08:50 -0700 (PDT) Subject: Re: [python][patch] Python rbreak From: Phil Muldoon To: "gdb-patches@sourceware.org" References: Message-ID: <551c566b-1767-71f8-50cd-260acbb20d40@redhat.com> Date: Fri, 13 Oct 2017 08:08:00 -0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00341.txt.bz2 On 11/10/17 12:30, Phil Muldoon wrote: > This introduces a Python rbreak function to the Python API. Its > functionality was designed to closely match that of the console rbreak > but with a number of caveats. > + > + gdbpy_ref<> argList (Py_BuildValue("(s)", symbol_name.c_str ())); > + gdbpy_ref<> obj (PyObject_CallObject ((PyObject *) > + &breakpoint_object_type, > + argList.get ())); > + > + /* Tolerate individual breakpoint failures. */ > + if (obj == NULL) > + gdbpy_print_stack (); > + else > + { > + PyTuple_SET_ITEM (return_tuple.get (), count, obj.get ()); > + count++; Not sure how I missed this on the first patch run, but that obj.get () should be obj.release (). Apologies for noise and fixed locally. Cheers Phil