On 04/03/2015 02:47 PM, Joel Brobecker wrote:
> This is OK, thank you, Pierre-Marie.

Cool! Thank you for the review!

> Note that the parameter "top_level" is no longer useful after
> this patch is applied, which is actually quite a nice side-effect
> of this patch. I hum'ed and ah'ed about whether to ask that it be
> removed as part of this patch, but in the end, I decided that this patch
> was fine without the cleanup, as "top_level" is used a several places,
> and I felt that cleaning it up here would dilute a bit the essence of
> this patch.  So, I think we can clean it up separately.

Oh, you are right, I did not notice this. The attached patch does this 
cleanup. No regression on x86_64-linux. Better to push these two in the 
same time. ;-)

[PATCH] gdbtypes.c: remove the usuned "top_level" parameter

This paramater is no longer useful after the previous commit, so remove
it as a cleanup.

gdb/ChangeLog:

         * gdbtypes.c (is_dynamic_type_internal): Remove the unused
         "top_level" parameter.
         (resolve_dynamic_type_internal): Remove the unused "top_level"
         parameter.  Update call to is_dynamic_type_internal.
         (is_dynamic_type): Update call to is_dynamic_type_internal.
         (resolve_dynamic_range): Update call to
         resolve_dynamic_type_internal.
         (resolve_dynamic_union): Likewise.
         (resolve_dynamic_struct): Likewise.
         (resolve_dynamic_type): Likewise.

-- 
Pierre-Marie de Rodat