From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83770 invoked by alias); 1 Apr 2015 12:17:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83758 invoked by uid 89); 1 Apr 2015 12:17:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Apr 2015 12:17:56 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t31CHttv017745 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 1 Apr 2015 08:17:55 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t31CHrMt009403; Wed, 1 Apr 2015 08:17:54 -0400 Message-ID: <551BE1F1.4020008@redhat.com> Date: Wed, 01 Apr 2015 12:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 0/9] New default sysroot "target:" References: <1426870087-32654-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1426870087-32654-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00034.txt.bz2 On 03/20/2015 04:47 PM, Gary Benson wrote: > Hi all, > > This series introduces a new "target:" prefix to "set sysroot". Files > specified with a "target:" prefix will be loaded via the target: from > the remote if the target is remote, and from the local file system > otherwise. This new prefix replaces the "remote:" prefix, and the > final patch in the series makes it the default. > > The way the "target:" prefix is implemented differs somewhat from the > way the "remote:" prefix was implemented: > > - It's hooked in at a lower level. The remote stuff looked to have > been added piecemeal: various BFD-opening functions did checks on > their filenames and diverted to remote_bfd_open. There was also > gdb_bfd_open_maybe_remote, which handled both local and remote > cases. The "target:" prefix is baked into gdb_bfd_open, so all > functions that open BFDs gain support. > > - Various functions locally strip the "target:" prefix from the > filenames they're working on if the target filesystem is the > same as the local filesystem. This serves two purposes: > > 1) It ensures files accessed locally are handled the same > way regardless of how they are specified. Things like > the shared library search algorithm in solib_find, for > example. > > 2) It avoids cluttering GDB's output with "target:" prefixes. > > Built and regtested on RHEL 6.6 x86_64. > > Ok to commit? Awesome work. Please remember to update the LocalRemoteFeatureParity page once this is in. Thanks, Pedro Alves