From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76646 invoked by alias); 1 Apr 2015 12:15:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76634 invoked by uid 89); 1 Apr 2015 12:15:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Apr 2015 12:15:17 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id E890E9177F for ; Wed, 1 Apr 2015 12:15:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t31CFE6t027689; Wed, 1 Apr 2015 08:15:15 -0400 Message-ID: <551BE151.4070900@redhat.com> Date: Wed, 01 Apr 2015 12:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 8/9] Make the default sysroot be "target:" References: <1426870087-32654-1-git-send-email-gbenson@redhat.com> <1426870087-32654-9-git-send-email-gbenson@redhat.com> In-Reply-To: <1426870087-32654-9-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00032.txt.bz2 On 03/20/2015 04:48 PM, Gary Benson wrote: > This commit makes GDB default to a sysroot of "target:". > One testcase needed updating as a result of this change. That's because when the sysroot is "target:" and the filesystem is remote, the sysroot is stripped from the "Inferior loaded" message, right? A short comment in the test would help. OK with that change. Thanks, Pedro Alves > > gdb/ChangeLog: > > * main.c (captured_main): Set gdb_sysroot to "target:" > if not otherwise set. > > gdb/testsuite/ChangeLog: > > * gdb.base/break-probes.exp: Cope with "target:" sysroot. > --- > gdb/ChangeLog | 5 +++++ > gdb/main.c | 6 ++++++ > gdb/testsuite/ChangeLog | 4 ++++ > gdb/testsuite/gdb.base/break-probes.exp | 2 +- > 4 files changed, 16 insertions(+), 1 deletions(-) > > diff --git a/gdb/main.c b/gdb/main.c > index 72b8714..8f276b4 100644 > --- a/gdb/main.c > +++ b/gdb/main.c > @@ -548,6 +548,12 @@ captured_main (void *data) > gdb_sysroot = relocate_gdb_directory (TARGET_SYSTEM_ROOT, > TARGET_SYSTEM_ROOT_RELOCATABLE); > > + if (gdb_sysroot == NULL || *gdb_sysroot == '\0') > + { > + xfree (gdb_sysroot); > + gdb_sysroot = xstrdup (TARGET_SYSROOT_PREFIX); > + } > + > debug_file_directory = relocate_gdb_directory (DEBUGDIR, > DEBUGDIR_RELOCATABLE); > > diff --git a/gdb/testsuite/gdb.base/break-probes.exp b/gdb/testsuite/gdb.base/break-probes.exp > index 1591c33..d4d756f 100644 > --- a/gdb/testsuite/gdb.base/break-probes.exp > +++ b/gdb/testsuite/gdb.base/break-probes.exp > @@ -72,7 +72,7 @@ if { $using_probes } { > while { $not_loaded_library } { > set not_loaded_library 0 > gdb_test_multiple "c" $test { > - -re "Inferior loaded $sysroot$binfile_lib\\M.*$gdb_prompt $" { > + -re "Inferior loaded ($sysroot)?$binfile_lib\\M.*$gdb_prompt $" { > pass $test > } > -re "Stopped due to shared library event\\M.*$gdb_prompt $" {