From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121441-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 73788 invoked by alias); 1 Apr 2015 12:13:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 73778 invoked by uid 89); 1 Apr 2015 12:13:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Apr 2015 12:13:57 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t31CDtke016317	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL)	for <gdb-patches@sourceware.org>; Wed, 1 Apr 2015 08:13:56 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t31CDsR0007606;	Wed, 1 Apr 2015 08:13:54 -0400
Message-ID: <551BE101.6040103@redhat.com>
Date: Wed, 01 Apr 2015 12:13:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/9] Convert "remote:" sysroots to "target:" and remove "remote:"
References: <1426870087-32654-1-git-send-email-gbenson@redhat.com> <1426870087-32654-5-git-send-email-gbenson@redhat.com>
In-Reply-To: <1426870087-32654-5-git-send-email-gbenson@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-04/txt/msg00029.txt.bz2

Looks good.

On 03/20/2015 04:48 PM, Gary Benson wrote:
> +/* Wrapper for reload_shared_libraries that replaces "remote:"
> +   at the start of gdb_sysroot with "target:".  */
> +
> +static void
> +gdb_sysroot_changed (char *ignored, int from_tty,
> +		     struct cmd_list_element *e)
> +{
> +  const char *old_prefix = "remote:";
> +  const char *new_prefix = TARGET_SYSROOT_PREFIX;
> +
> +  if (startswith (gdb_sysroot, old_prefix))
> +    {
> +      gdb_assert (strlen (old_prefix) == strlen (new_prefix));
> +      memcpy (gdb_sysroot, new_prefix, strlen (new_prefix));

Should this output a warning (once per gdb invocation)?

> +    }
> +
> +  reload_shared_libraries (ignored, from_tty, e);
> +}
> +


Thanks,
Pedro Alves