From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68597 invoked by alias); 1 Apr 2015 12:11:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68588 invoked by uid 89); 1 Apr 2015 12:11:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Apr 2015 12:11:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t31CBNIl014915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 1 Apr 2015 08:11:23 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t31CBLOY005943; Wed, 1 Apr 2015 08:11:22 -0400 Message-ID: <551BE069.4040502@redhat.com> Date: Wed, 01 Apr 2015 12:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 1/9] Introduce target_fileio_fstat References: <1426870087-32654-1-git-send-email-gbenson@redhat.com> <1426870087-32654-2-git-send-email-gbenson@redhat.com> In-Reply-To: <1426870087-32654-2-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00025.txt.bz2 Looks good with the nits below addressed. On 03/20/2015 04:47 PM, Gary Benson wrote: > --- a/gdb/inf-child.c > +++ b/gdb/inf-child.c > @@ -374,6 +374,22 @@ inf_child_fileio_pread (struct target_ops *self, > return ret; > } > > +/* Get information about the file opened as FD and put it in SB. > + Return 0, or -1 if an error occurs (and set *TARGET_ERRNO). */ Write something like "Implementation of to_fileio_fstat." instead of duplicating the comment. > + > +static int > +inf_child_fileio_fstat (struct target_ops *self, int fd, > + struct stat *sb, int *target_errno) > +{ > index bb901b5..44ede10 100644 > --- a/gdb/target.c > +++ b/gdb/target.c > @@ -2848,6 +2848,27 @@ target_fileio_pread (int fd, gdb_byte *read_buf, int len, > return ret; > } > > +/* Get information about the file opened as FD on the target > + and put it in SB. Return 0, or -1 if an error occurs (and > + set *TARGET_ERRNO). */ Write: /* See target.h. */ instead of duplicating the comment. > +int > +target_fileio_fstat (int fd, struct stat *sb, int *target_errno) > +{ > + fileio_fh_t *fh = fileio_fd_to_fh (fd); > + int ret = -1; > + > + if (is_closed_fileio_fh (fh->fd)) > + *target_errno = EBADF; > + else > + ret = fh->t->to_fileio_fstat (fh->t, fh->fd, sb, target_errno); > + > + if (targetdebug) > + fprintf_unfiltered (gdb_stdlog, > + "target_fileio_fstat (%d) = %d (%d)\n", > + fd, ret, ret != -1 ? 0 : *target_errno); > + return ret; > +} > + > /* Close FD on the target. Return 0, or -1 if an error occurs > (and set *TARGET_ERRNO). */ > int > diff --git a/gdb/target.h b/gdb/target.h > index c95e1a4..d2bd152 100644 > --- a/gdb/target.h > +++ b/gdb/target.h > @@ -846,6 +846,11 @@ struct target_ops > int fd, gdb_byte *read_buf, int len, > ULONGEST offset, int *target_errno); > > + /* Get information about the file opened as FD and put it in SB. > + Return 0, or -1 if an error occurs (and set *TARGET_ERRNO). */ ITYM, "Return 0 on success, ..." > + int (*to_fileio_fstat) (struct target_ops *, > + int fd, struct stat *sb, int *target_errno); > + > +/* Get information about the file opened as FD on the target > + and put it in SB. Return 0, or -1 if an error occurs (and Likewise. > + set *TARGET_ERRNO). */ > +extern int target_fileio_fstat (int fd, struct stat *sb, > + int *target_errno); Thanks, Pedro Alves