Joel,

On 03/23/2015 02:36 PM, Joel Brobecker wrote:
> If it cannot pass without your GCC patch, let's add a setup_xfail.

Done.

> Mostly OK - a couple of minor comments below.
> [...]
> If the test "label" (3rd argument) is the same as the command being
> sent, you do not need to explicitly specify it. So, the following
> is equivalent to your version:
>
>          gdb_test "p get (\"Hello world!\")" \
>                   "= \\(n => 12, s => \"Hello world!\"\\)"
>
>> +gdb_test "ptype get (\"Hello world!\")" \
>> +         [multi_line "type = <ref> record" \
>> +                     "    n: natural;" \
>> +                     "    s: access array \\(1 \\.\\. n\\) of character;" \
>> +                     "end record"] \
>> +         "ptype get (\"Hello world!\")"
>
> Same here.

Fixed both.

>> +++ b/gdb/testsuite/gdb.ada/funcall_ref/foo.adb
>> @@ -0,0 +1,19 @@
>> +procedure Foo is
>
> Missing copyright header.

Likewise.

Here's the updated patch. Thank you for reviewing!

-- 
Pierre-Marie de Rodat