From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121385-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23475 invoked by alias); 31 Mar 2015 15:11:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23466 invoked by uid 89); 31 Mar 2015 15:11:07 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 31 Mar 2015 15:11:06 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2VFB4NZ008729	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Tue, 31 Mar 2015 11:11:04 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2VFB2k6004993;	Tue, 31 Mar 2015 11:11:03 -0400
Message-ID: <551AB906.1020801@redhat.com>
Date: Tue, 31 Mar 2015 15:11:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "H.J. Lu" <hjl.tools@gmail.com>
CC: GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add --with-system-zlib in gdb
References: <20150331112712.GA22591@gmail.com>	<20150331115151.GA25736@gmail.com>	<CAMe9rOoR1Dqp+mdVQg9PyPLeNkEwP8iPYRfNW=PnSnezd_4Ebw@mail.gmail.com>	<551AA89C.1050604@redhat.com> <CAMe9rOrGomkR8PcQCoVbfstx8Wi8B9DuPD8wy4q0X_FUHiV0wg@mail.gmail.com>
In-Reply-To: <CAMe9rOrGomkR8PcQCoVbfstx8Wi8B9DuPD8wy4q0X_FUHiV0wg@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-03/txt/msg01049.txt.bz2

On 03/31/2015 03:56 PM, H.J. Lu wrote:
> On Tue, Mar 31, 2015 at 7:01 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 03/31/2015 02:46 PM, H.J. Lu wrote:
>>> --- a/gdb/acinclude.m4
>>> +++ b/gdb/acinclude.m4
>>> @@ -467,7 +467,11 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [
>>>    CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
>>>    LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
>>>    intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
>>> -  LIBS="-lbfd -liberty $intl $LIBS"
>>> +  if test -f ../zlib/Makefile; then
>>> +    LIBS="-lbfd -L../zlib -lz -liberty $intl $LIBS"
>>> +  else
>>> +    LIBS="-lbfd -lz -liberty $intl $LIBS"
>>> +  fi
>>
>> Seems quite fragile to have to configure and generate the zlib
>> Makefile first.  Why isn't this simply:
>>
>>    LDFLAGS="-L../bfd -L../libiberty $zlibdir $LDFLAGS"
>>
>> ?
> 
> It works.  Here is the updated patch for gdb.  OK for master?

OK.

Thanks,
Pedro Alves