From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62183 invoked by alias); 30 Mar 2015 20:51:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62168 invoked by uid 89); 30 Mar 2015 20:51:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: bin-vsp-out-02.atm.binero.net Received: from vsp-authed01.binero.net (HELO bin-vsp-out-02.atm.binero.net) (195.74.38.224) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 30 Mar 2015 20:51:18 +0000 X-Halon-ID: 7efeec84-d71e-11e4-8eab-005056917f90 Authorized-sender: jiri@gaisler.se Received: from [192.168.9.20] (unknown [78.68.139.28]) by bin-vsp-out-02.atm.binero.net (Halon Mail Gateway) with ESMTPA for ; Mon, 30 Mar 2015 22:51:10 +0200 (CEST) Message-ID: <5519B733.3000402@gaisler.se> Date: Mon, 30 Mar 2015 20:51:00 -0000 From: Jiri Gaisler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH v4 13/13] Add watchpoint support to gdb simulator interface. References: <1426626170-21401-1-git-send-email-jiri@gaisler.se> <1426626170-21401-14-git-send-email-jiri@gaisler.se> <20150328071943.GN30239@vapier> In-Reply-To: <20150328071943.GN30239@vapier> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4mGAfm6wHr335Onv1K4aG741spPOI6GPu" X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg01017.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4mGAfm6wHr335Onv1K4aG741spPOI6GPu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1654 On 28/03/15 08:19, Mike Frysinger wrote: > On 17 Mar 2015 22:02, Jiri Gaisler wrote: >> Currently, only the sparc sim supports watchpoints. Stubs for the >> watchpoint functions were added to all other built-in sims >> to avoid linking errors. >=20 > i haven't looked too closely here, but we already have common/sim-watch.c= . how=20 > does this interact with that ? This is interesting. The sim-watch.c seems only to define PC watchpoints, i.e. what I would call (hardware) breakpoints. There does not seem to be any support for data watchpoints like we have in sis. As far as I can see, only the ARM simulator also implements data watchpoints but does not export it to gdb. This is probably because the target_ops structure for gdb= sim does not export the (data) watchpoint functionality. My patch extends the target_ops structure to include the gdb watchpoint interface, and provide dummy functions for all simulators to avoid linking errors. It does not modify or interfere with the sim-watch.c since the functions are different. Ideally, common/sim-watch.c could be updated to also support data watchpoints but it is beyond my capability at this point. The code does not seem to have been touched since 1998 btw. I propose to add my code as it currently stands in common/sim-watch-remote.= c, but rename it to sim-watch-data.c. By adding the watchpoint interface to the target_ops, any maintainer could then map potential watchpoint support in a simulator on the gdb interface. If the sim/common framework is extended to support this, then more simulators will obviously benefit. >=20 > also missing ChangeLog entries Will fix. Jiri. --4mGAfm6wHr335Onv1K4aG741spPOI6GPu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 884 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJVGbdBAAoJEIAIwBKmO2+bcmEQAMyQLIRbWSybC8GOSxrxkwd2 TaxT/VSo9+8GTQD0RTnaQHOsJ4l7+Dzjr8AVWNFtXQx6eK/8jhJufLSbkH3p27ev IHy2fICIXVwtfJkzJx2xDL+5XHmsZ2x8McRQhTZ2jdpi0FUo73SDyaGO5dijaSQO CZHrspDVG1lGNjPumNyiC8RufypnBQFzgLZgrhzK1rMkffPsYkLk9y/4bCbdQMEk 99Ikd4AOb8iwkqbY9EXB6FGHvmJHdquBsUql5uVwyvAhIVHRCOt7gRget6X5zef4 sHsDKS+cwCq8BXWfN2NBW2zYvJPjVfODX3Qv+xWulMS3SxJPSjVjsuAFb3lsw2KI ISJ7ZrdFxNk/hNusSqT5Ule7dTr93MhV8jaci8JsWYkkYmxEBPxFtD3BVNZfYMZY 0Xnyqr66MiQNCEWwUwmpZllkKVVliL9DCHN8H8dNS8AtBoifs7vjuFZZiqVBTQ4C x6kRoTgwuRFIEtsgTjsBwD+73LMp/lp00lwbBEPaLOYNEsFEBaT1uS8B4WsTJcHH vk+weNa7y/36YoyPI2KJzuYqHimkOpA71+ZhDY+hAcmYGhWaz4ffVCGce7aeL1Ui 7cQ08SbWXMTwnsVeDOl++12cNgK5pK9vq6wSkxi0FIjzLddec/6HQ5hBdkMnlcK1 WQ19TGZ/NullstHIFKad =u0er -----END PGP SIGNATURE----- --4mGAfm6wHr335Onv1K4aG741spPOI6GPu--