From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30182 invoked by alias); 27 Mar 2015 17:13:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30169 invoked by uid 89); 27 Mar 2015 17:13:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 27 Mar 2015 17:13:01 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id A8.6E.17241.E8D25155; Fri, 27 Mar 2015 11:14:38 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.210.2; Fri, 27 Mar 2015 13:12:55 -0400 Message-ID: <55158F97.7030400@ericsson.com> Date: Fri, 27 Mar 2015 17:13:00 -0000 From: Antoine Tremblay User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Keith Seitz , Subject: Re: [PATCH] Fix MI dprintf-insert not printing when a location is pending. References: <55154E63.5040603@ericsson.com> <1427459819-29661-1-git-send-email-antoine.tremblay@ericsson.com> <55158AAF.7010709@redhat.com> In-Reply-To: <55158AAF.7010709@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00915.txt.bz2 On 03/27/2015 12:51 PM, Keith Seitz wrote: > On 03/27/2015 05:36 AM, Antoine Tremblay wrote: >> diff --git a/gdb/testsuite/gdb.mi/mi-dprintf-pending.exp >> b/gdb/testsuite/gdb.mi/mi-dprintf-pending.exp >> new file mode 100644 >> index 0000000..6185329 >> --- /dev/null >> +++ b/gdb/testsuite/gdb.mi/mi-dprintf-pending.exp > ... > >> +set msg "mi dprintf" >> +gdb_expect { >> + -re ".*~\"hello\"" { >> + pass $msg >> + } >> + -re ".*$mi_gdb_prompt$" { >> + fail $msg >> + } >> + timeout { >> + fail $msg >> + } >> +} > > Pending a previous query about using mi_gdb_test here, I recommend a > maintainer approve this patch. > Indeed I had missed that you can call it without a command, my mind must have skipped that line, thanks :) However there is still a problem forcing me to use gdb_expect I think, namely mi_gdb_test waits for a command prompt like so : -re "^($string_regex\[\r\n\]+)?($pattern\[\r\n\]+$mi_gdb_prompt\[ \]*)" However dprintf does mean you will get a prompt printed... You will get a prompt only when hitting the breakpoint I placed. This means that if for some reason the breakpoint would not hit, the dprintf test would fail, when it's the breakpoint that should fail. I could remove mi_expect_stop at the end and assume that breakpoint will not fail but I think it's not right ? also mi-dprintf.exp is using the same mi_run_cmd / gdb_expect / mi_expect_stop ... What do you think ?