From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77027 invoked by alias); 27 Mar 2015 10:20:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77016 invoked by uid 89); 27 Mar 2015 10:20:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Mar 2015 10:20:33 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2RAKV54029119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Mar 2015 06:20:31 -0400 Received: from localhost.localdomain (ovpn-112-84.ams2.redhat.com [10.36.112.84]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2RAKTHx005272; Fri, 27 Mar 2015 06:20:30 -0400 Message-ID: <55152EED.6060902@redhat.com> Date: Fri, 27 Mar 2015 10:20:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Eli Zaretskii , Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] compile: New 'compile print' References: <20150326205727.28223.54648.stgit@host1.jankratochvil.net> <20150326205752.28223.24230.stgit@host1.jankratochvil.net> <83iodmnc18.fsf@gnu.org> <20150327073333.GA28529@host1.jankratochvil.net> <83d23unazo.fsf@gnu.org> <55150D18.6020308@redhat.com> <838uein6un.fsf@gnu.org> <20150327091617.GA1488@host1.jankratochvil.net> <834mp6bw71.fsf@gnu.org> In-Reply-To: <834mp6bw71.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00893.txt.bz2 On 27/03/15 09:56, Eli Zaretskii wrote: >> Date: Fri, 27 Mar 2015 10:16:17 +0100 >> From: Jan Kratochvil >> Cc: Phil Muldoon , gdb-patches@sourceware.org >> >>> Can it include calls to standard functions? Can it call functions from >>> libraries other than libc? What about functions defined by the inferior? >> q>> yes, yes (as long as the library is already DT_NEEDEDed or dlopen()ed by the >> inferior), yes. > > Are you sure the last part (calling functions in the inferior) will > work on all platforms? How does the GCC plugin know to resolve the > address of the inferior's functions correctly? Won't it need some > kind of import library on Windows? Via the address translation oracle. This is no different from the compile code/file mechanism that was reviewed and committed some months ago. Does it work on all platforms? I can't answer that as I do not have access to all platforms. Few people, I suspect, do. But this is pretty much true of every patch submitted in GDB. But if it doesn't work then the error handling mechanisms of GDB and GCC plugin should handle it. Just like any other platform dependent bugs. As always if people on those platforms file bugs, we will always gladly help fix them. On the issue of compile print and preconceived notions by users regarding the utility of the function, then it is a documentation issue. Your assertion of what the user "might think" can easily be remedied by documentation fixes to the help command and/or the manual. This will help correct any previous notions, and guide them to what they should think of the command. Other than the edits you have suggested (thank you for those!) do you have any additional documentation edits that might help to address the preconceived notions the user might have? Cheers Phil