Re: [PATCH v7 1/1] gdb, configure: Add enable-binary-file-format option for configure

Guinevere Larsen
2025-08-14T16:24:16Z

On 8/14/25 12:39 PM, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:
> Guinevere> GDB has support for many binary file formats, some which might be very
> Guinevere> unlikely to be found in some situations (such as the XCOFF format in
> Guinevere> an x86 system). This commit introduces the option for a user to choose
> Guinevere> which formats GDB will support at build configuration time.
>
> I think you addressed all the review comments.
> This looks fine to me.
>
> Approved-By: Tom Tromey <tom@tromey.com>
Thank you! pushed!
>
> Guinevere> Mach-O and elf support are also dependent on BFD support being compiled
> Guinevere> in. In case one of those was requested and BFD does not support them,
> Guinevere> the following error is emitted:
>
> I don't recall - was there a reason this isn't entirely BFD-centric?
> Like, some option to disable formats in BFD and then gdb would just
> adapt to this?

Mainly because it wouldn't work with the format of
--enable-binary-file-format (I think anyway).

These attack surface patches were my first experience with autotools, so
I wanted to make things as simple as possible while remaining consistent.

--
Cheers,
Guinevere Larsen
She/it