From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36758 invoked by alias); 26 Mar 2015 09:24:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36745 invoked by uid 89); 26 Mar 2015 09:24:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Mar 2015 09:24:32 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2Q9OTdY023098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 26 Mar 2015 05:24:29 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2Q9ORds001255; Thu, 26 Mar 2015 05:24:28 -0400 Message-ID: <5513D04B.1070602@redhat.com> Date: Thu, 26 Mar 2015 09:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Doug Evans , Andrew Burgess CC: gdb-patches Subject: Re: [PATCH] gdb: New frame_cache_cleared observer. References: <1427303468-17834-1-git-send-email-andrew.burgess@embecosm.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00844.txt.bz2 On 03/25/2015 11:18 PM, Doug Evans wrote: > On Wed, Mar 25, 2015 at 10:11 AM, Andrew Burgess > wrote: >> This adds a new observer for the frame cache cleared event. >> >> While working on a new gdb port I found that I wanted to cache machine >> state that was gathered as part of the register read process. The >> most appropriate time to discard this cached information is when the >> frame cache is flushed. >> >> However, as I don't have an actual use for this observer that I can >> post upstream (yet) I don't know if this will be acceptable, but given >> it's a fairly small change I thought I'd try. ... >> gdb/ChangeLog: >> >> * frame.c (reinit_frame_cache): Trigger frame_cache_cleared >> observers. > > Hi. > > AIUI, our rules for dead code elimination preclude such a patch being applied. > > I can go either way on this particular patch myself, but those are the rules > (as I understand them). > Right. We delete dead code all the time. So it's better to wait until is has a use, because otherwise someone could well end up stumbling on it, noticing it has no uses and decides to send a patch that garbage collects it. Thanks, Pedro Alves