From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kPhUBSkwXGi50R4AWB0awg (envelope-from ) for ; Wed, 25 Jun 2025 13:21:45 -0400 Received: by simark.ca (Postfix, from userid 112) id 082961E11E; Wed, 25 Jun 2025 13:21:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6DE421E0C2 for ; Wed, 25 Jun 2025 13:21:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1CBBC385AC24 for ; Wed, 25 Jun 2025 17:21:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1CBBC385AC24 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id 496353857C67 for ; Wed, 25 Jun 2025 17:21:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 496353857C67 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 496353857C67 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750872074; cv=none; b=JEr4+1h8QTutSHgEpjiCQRjq5HU9hK1rlUwxOMraORxkDG+lS+Xj7/N8pxxAPOaGpjpt6M0sN9b0dSpzREdKxY7W/4Oqf/YEbJ514aFQB8QMieUudjUtc4Y9MFGp3HQf6U4NS6Qj5jQ/ofs0w+stgs7UOUS2DorfmrsHRp3Y/vs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750872074; c=relaxed/simple; bh=eqRpU5dnxL1yZO487SkwBBNKgg1sHoqUFhKVnnmiV+Q=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=fffgpJ9qOrn1Z27okKu4njWwki2V6qsnte49kd4FTfSGU/P3sP+vFONLGNm5HNfdyxxq4LTiUDx+WrQcx1XDyYfmY8Y4XKB4g8TokO6scteUC2bJHw6j0eLNftAuLqmJaSRbMGYNQzTXzShTLwUJ4zf6KDqEl8dMZ0iJqyO11nU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 496353857C67 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-451d6ade159so468325e9.1 for ; Wed, 25 Jun 2025 10:21:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750872073; x=1751476873; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pnCcFQ+Dr1j5lEUBh7qvf9WP9G6cB7BIfCsqJf1W8/Q=; b=IdxsOp38+W9+9GbXFYG+7XQnFWXvuKSCdpqJgz4i23u1zm2z28wj2PU33WKyD5+fzd pODN7s5yD2gg3yeE6fOcHh/hfwHoMwWkbSS+odslgY76lUE6NJ7vdPXjcc+8qQANfmKB GLGbdvjtRN5QZYRTl+U5zvWJl3YDufmZNqkNVDJ/w6rO/f8qPjeh4YvuCSDXxIKT8MkV tw3WM6mPgJERyuIG7HLWSNjRaP1GpygzIxGaucqZ9xB3bB4AOG3iHZA2ZNDf82YvVOmK FAVPXkRAkeQ7HvaaWW5x7kcivUYPoOwf+jiKx+c5ZGP2fX9A9FCD6udIIoiEmPLBBZtk AZ9Q== X-Gm-Message-State: AOJu0Yx3fK792GtTX7FaH8EVwG0WTx06NHbaRKThBRkzPksL7H4rJPUg C6jdi8fNMVxxplxYi1LLEI4mTvvyV3/jmhaSTkFPINAQkYZ1xsrigMto X-Gm-Gg: ASbGncv9OO50mW6UhIufeaOLAa0A6+agMBtvXzHcxhNE0c3i8+cunih+zc3BPwQobex YFov11WAymmtKdMQFVn5/t4eJnGO9zYTZnfM6Rw5OcCcR7V+tFoQhSVGiFzQ3MiAndwU+LUOROS lNAtGEL+4D9bM95kjux9vqsJFWXExNt7qmbyGhYNReBgYWvNrxfeqGyRB0M3V4jdkLY0BK2a4d/ 9nUiME90H7334/4EaX6ugOauPKcyH+sqg9gDGAG9XN+DN78P1ZIJzjOU0S1MpohgHjdnWCMSYry eKrlmyeJS2PeU4fFOl2DI53VrCbxjsGwZWMTJIV1Tt9yYSyEqK0x2IHXEfZvlslW7UEvq8QK5b+ 0IWKL4eHO1GRD9UWzNfZh3h7R5enCOg== X-Google-Smtp-Source: AGHT+IGfzXR29GghGT1Wt07QQo7E4Ac2MnHxSB8g0XadFTqPnLVaPUfnHOJXoR5AaVh+KOtSxQz1yA== X-Received: by 2002:a05:600c:a407:b0:43c:f8fc:f697 with SMTP id 5b1f17b1804b1-45382a1d307mr33589205e9.9.1750872072868; Wed, 25 Jun 2025 10:21:12 -0700 (PDT) Received: from ?IPV6:2001:8a0:fac3:6d00:5314:95f5:d044:767a? ([2001:8a0:fac3:6d00:5314:95f5:d044:767a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e810010fsm5166757f8f.74.2025.06.25.10.21.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 10:21:12 -0700 (PDT) Message-ID: <5511fb41-26e1-491c-be82-9b6ad20a2d55@palves.net> Date: Wed, 25 Jun 2025 18:21:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] Allow check-mark to be changed for CLI To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250509-emoji-check-mark-v1-0-63b6c52411f3@adacore.com> <20250509-emoji-check-mark-v1-2-63b6c52411f3@adacore.com> <4045933d-2307-4c87-9fe8-5c941478510c@palves.net> <87tt45xeik.fsf@tromey.com> <9621fa1e-76bb-42ca-bcb7-bb8f0560a89d@palves.net> <87ldpfygha.fsf@tromey.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <87ldpfygha.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-06-25 16:43, Tom Tromey wrote: > Pedro> So maybe all we need is to base the "current" column's width > Pedro> depend on the wcwidth of the character used. > > I think to do this we'd need something better than wcwidth. See > appended. Also as Eli points out, the terminal itself can do something > other than whatever wcwidth reports. > > Tom > > #define _XOPEN_SOURCE > #include > #include > > #define C L"👉" > > int main() { > printf ("width = %d\n", wcswidth (C, wcslen (C))); > printf ("of char = %d\n", wcwidth (C[0])); > return 0; > } > > bapiya. gcc -o q q.c > bapiya. ./q > width = -1 > of char = -1 > That seems to be something with the locale. Yours returns -1 for me too, but the below returns 2: #define _XOPEN_SOURCE #include #include #include #define C L"👉" int main() { setlocale (LC_CTYPE, ""); printf ("width = %d\n", wcswidth (C, wcslen (C))); printf ("of char = %d\n", wcwidth (C[0])); return 0; } $ gcc wcwidth.c -o wcwidth $ ./wcwidth width = 2 of char = 2