From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50389 invoked by alias); 23 Mar 2015 20:09:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50372 invoked by uid 89); 23 Mar 2015 20:09:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Mar 2015 20:09:31 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 7E1888E927; Mon, 23 Mar 2015 20:09:30 +0000 (UTC) Received: from x220.homelab.tallawa.org ([10.3.112.10]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2NK9FwN003034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 23 Mar 2015 16:09:27 -0400 Message-ID: <551072E9.50805@redhat.com> Date: Mon, 23 Mar 2015 20:09:00 -0000 From: Cleber Rosa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org, areis@redhat.com Subject: Re: [PATCH 4/4] GDBServer: add 'monitor set server-stderr' command References: <1426905265-8495-1-git-send-email-crosa@redhat.com> <1426905265-8495-5-git-send-email-crosa@redhat.com> <831tkivjmh.fsf@gnu.org> In-Reply-To: <831tkivjmh.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00749.txt.bz2 On 03/21/2015 05:29 AM, Eli Zaretskii wrote: >> From: Cleber Rosa >> Cc: crosa@redhat.com, areis@redhat.com >> Date: Fri, 20 Mar 2015 23:34:25 -0300 >> >> gdb/doc/Changelog: >> 2015-03-20 Cleber Rosa >> >> * gdb.texinfo (info): Add documentation about the 'monitor set >> server-stderr' command > Don't forget the period at the end of the sentence. > >> +@item monitor set server-stderr [PATH] > You want "[@var{path}]" instead. And please don't call this "path", > for the reasons I explained in my other message. Sure! BTW, I mistakenly added [PATH] as an optional parameter, and it should be mandatory. Because of that, this is the new version: @item monitor set server-output @var{output_filename} Redirect the server output to a file given by @var{output_filename}. Also, FIY, the server behavior when the "output_filename" parameter is not passed in, is currently the same as when a parameter is missing from another commands such as "monitor set remote-debug": (gdb) monitor set server-output Unknown monitor command. ... Protocol error with Rcmd (gdb) monitor set remote-debug Unknown monitor command. ... Protocol error with Rcmd It looks like this is an area that can receive some improvement, but it's obviously outside the scope of the changes proposed/worked here. > >> +Redirect the server stderr to a file given by @var{path}. > Same comments as in my other message: instead of referencing "stderr", > reference the server's output. > > Thanks. Sure! I should really have learned that lesson by now! Thanks a million!