From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130602 invoked by alias); 23 Mar 2015 09:01:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130587 invoked by uid 89); 23 Mar 2015 09:01:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: bin-vsp-out-03.atm.binero.net Received: from vsp-unauthed01.binero.net (HELO bin-vsp-out-03.atm.binero.net) (195.74.38.225) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Mar 2015 09:01:09 +0000 X-Halon-ID: 212f7b53-d13b-11e4-9958-0050569116f7 Authorized-sender: jiri@gaisler.se Received: from [192.168.9.20] (unknown [78.68.173.120]) by bin-vsp-out-03.atm.binero.net (Halon Mail Gateway) with ESMTPA for ; Mon, 23 Mar 2015 10:01:01 +0100 (CET) Message-ID: <550FD646.7040905@gaisler.se> Date: Mon, 23 Mar 2015 09:01:00 -0000 From: Jiri Gaisler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH v4 03/13] sim/erc32: Switched emulated memory to host endian order. References: <1426626170-21401-1-git-send-email-jiri@gaisler.se> <1426626170-21401-4-git-send-email-jiri@gaisler.se> <20150323024519.GB8039@vapier> In-Reply-To: <20150323024519.GB8039@vapier> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0i7sDkD63fRwaQBNjlgBnAqnL1O3hL1Bg" X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00710.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0i7sDkD63fRwaQBNjlgBnAqnL1O3hL1Bg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 496 On 23/03/15 03:45, Mike Frysinger wrote: > On 17 Mar 2015 22:02, Jiri Gaisler wrote: >> --- a/sim/erc32/erc32.c >> +++ b/sim/erc32/erc32.c >> +#ifdef HOST_LITTLE_ENDIAN >> + waddr ^=3D 3; >> +#endif >> + mem[waddr] =3D *data & 0x0ff; >=20 > doesn't this assume the target is big endian ? this shows up a few times= in=20 > the changes to this file. >=20 The target (SPARC) is always big endian, so I believe this is correct. I will fix the rest of your comments and resend. Jiri. --0i7sDkD63fRwaQBNjlgBnAqnL1O3hL1Bg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 884 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJVD9ZPAAoJEIAIwBKmO2+bwWIP/3d9mh1ut0jolGQKrdyny/4O fmXGd3TxaKt07Dr98pdTnpQ6wlf61ZCMdaDZ7RbAE4dZVzVLZETJR+XYAV6iHgAX M/3nITdPYmMF6ujWGhdgTzwBEe0vW6wY6sXMr1oQJsUvYYV0UnDWlxqusDUFIufI yU0iDyV78tdniVA35R2M5LIwglzwktrZHijpaR3B5ylsQE+YXtbjBRv9W9g0SGXc fcGBBDiiA2AxtC0K+Ent486wLwSTrAejBw10cJVntGQINo6kRT7M3JrLJ9q/1oXv pOLiMPugaUKAMctV/IezsiNPr3drAxwxLx8u5ALImYFY9svg5TXso/mUe4XlhveS 1INydXRYr9J1anCmK4dRafkzqwyUwxd0UI5fEaZ6uFGDHmfm903HhJ1XLpRT0mKu lCzTBz0vx+4l96niPa6INrKZutxIXvv1EFoWgdqX2yn5Iv+kAqEjx2alTpDr3wV2 apOLRpHSVT2DdyVTIHDxl5pHEGLsVNgJOI1Zgp0Tfh9MrIxGHh+lSQGAoOfrulT+ IDK+GT5gADfrw/WShMKkCKcWyiio5qGRW58Vfd857ikmEi8o+JX1hzmIoykeF/IO 1dz8YaOUQxQgHtWS6b71zgXBgmPi36Z8KeoTtMdLcl3hbLtmXCbeW3kv1mBTR4kv cPi0JqecqYu6g9hnagWw =q/TP -----END PGP SIGNATURE----- --0i7sDkD63fRwaQBNjlgBnAqnL1O3hL1Bg--