From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16392 invoked by alias); 20 Mar 2015 18:00:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16369 invoked by uid 89); 20 Mar 2015 18:00:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Mar 2015 18:00:28 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2KI0OQG029929 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Mar 2015 14:00:24 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2KI0Mb9016158; Fri, 20 Mar 2015 14:00:23 -0400 Message-ID: <550C6036.7040106@redhat.com> Date: Fri, 20 Mar 2015 18:00:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Pierre-Marie de Rodat , Joel Brobecker CC: GDB Patches Subject: Re: [PATCH] Share the "multi_line" helper among all Ada testcases References: <54FEDB92.9060808@adacore.com> <20150317200809.GD7494@adacore.com> <5509492C.5000604@redhat.com> <20150318141238.GE7494@adacore.com> <550C100D.5000500@adacore.com> In-Reply-To: <550C100D.5000500@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00666.txt.bz2 Looks great to me. Many thanks for doing this. Spotted a tiny typo: On 03/20/2015 12:18 PM, Pierre-Marie de Rodat wrote: > +# with a regexp that matches exactly one end of lines in between "end of line" Thanks, Pedro Alves