From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107474 invoked by alias); 20 Mar 2015 10:28:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107457 invoked by uid 89); 20 Mar 2015 10:28:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Mar 2015 10:28:40 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2KASceu019389 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 20 Mar 2015 06:28:38 -0400 Received: from [10.36.7.86] (vpn1-7-86.ams2.redhat.com [10.36.7.86]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2KASa27026316 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 20 Mar 2015 06:28:38 -0400 Message-ID: <550BF654.7070402@redhat.com> Date: Fri, 20 Mar 2015 10:28:00 -0000 From: Nicholas Clifton User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: dj@redhat.com, gdb-patches@sourceware.org Subject: Re: RFA: RL78: Fix simulation of G13 multiply/divide peripheral References: <87fv91nfy3.fsf@redhat.com> <20150319184231.GB4128@vapier> In-Reply-To: <20150319184231.GB4128@vapier> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00623.txt.bz2 Hi Mike, >> Tested with no regressions on an rl78-elf toolchain. > > how do you really know when there are no sim tests ? Because I use the sim to help run the gcc testsuite, and without this patch several gcc tests were failing due to errors from the sim about misaligned accesses to the MDB register. With this patch those failures went away and no new failures were introduced. Hence I felt confident that the patch was good. Cheers Nick