From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24864 invoked by alias); 19 Mar 2015 10:41:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24848 invoked by uid 89); 19 Mar 2015 10:41:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 19 Mar 2015 10:41:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 018FEAE5D0 for ; Thu, 19 Mar 2015 10:41:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2JAfjhc006243; Thu, 19 Mar 2015 06:41:46 -0400 Message-ID: <550AA7E9.2080406@redhat.com> Date: Thu, 19 Mar 2015 10:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Sergio Durigan Junior , GDB Patches Subject: Re: [PATCH 3/4] Implement support for checking /proc/PID/coredump_filter References: <1426707523-6499-1-git-send-email-sergiodj@redhat.com> <1426707523-6499-4-git-send-email-sergiodj@redhat.com> In-Reply-To: <1426707523-6499-4-git-send-email-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00579.txt.bz2 On 03/18/2015 07:38 PM, Sergio Durigan Junior wrote: > + /* If a mapping should not be dumped we still should create > + a segment for it, just without SEC_LOAD (see > + gcore_create_callback). */ I think this comment is stale now? > + if (has_anonymous) > + { > + if (dump_mapping_p (filterflags, &v, private, mapping_anon_p, > + filename)) > + modified_state = MEMORY_MAPPING_MODIFIED; > + else > + modified_state = MEMORY_MAPPING_UNMODIFIED; > + } > + else > + { > + /* Older Linux kernels did not support the "Anonymous:" counter. > + If it is missing, we can't be sure - dump all the pages. */ > + modified_state = MEMORY_MAPPING_UNKNOWN_STATE; > + } Thanks, Pedro Alves