Remove --xdb? (Re: [testsuite patch] Remove gdb.hp [Re: [patch] Remove HPUX])

[Pedro Alves <palves@redhat.com>]

On 03/13/2015 07:16 PM, Jan Kratochvil wrote:
> On Fri, 21 Nov 2014 04:20:04 +0100, Yao Qi wrote:
>> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>>
>>> I did not investigate too much which other parts of GDB could be removed
>>> along, there may be some dead code now (but it always has been).
>>
>> Directory testsuite/gdb.hp should be removed,
> 
> Attached, OK for check-in?
> 

I read through all this, and the only things that looked like could
be salvageable and mildly interesting would be the "gdb --xdb"
tests (in gdb.compat/).  But, the only reference to xdb found
in the manual is commented out:

@c @item -xdb
@c @cindex @code{--xdb}
@c Run in XDB compatibility mode, allowing the use of certain XDB commands.
@c For information, see the file @file{xdb_trans.html}, which is usually
@c installed in the directory @code{/opt/langtools/wdb/doc} on HP-UX
@c systems.

The commands that enables aren't even documented in the manual.
Judging from that, I assume that only wdb users would ever really
be using the --xdb switch.

I think it's time to drop "support" for the --xdb switch too.  I
looked through the commands that that exposes, the only that looked
potentially interesting was "go", but then it's just an alias
for "tbreak+jump", which can easily be done with "define go...end".
I'd rather free up the "go" name for something potentially
more interesting (either run control, or maybe even unrelated,
e.g., for golang).

So the patch looks good to go to me.

>> as well as some target triplet checking on hpux in testsuite/lib/gdb.exp.
> 
> To be done later, I have spent some time on it but it seems unclear to me what
> should / should not be deleted, GDB seems to assume in many cases hppa==hpux
> which is not always the case.

Thanks,
Pedro Alves