From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123591 invoked by alias); 18 Mar 2015 09:25:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123580 invoked by uid 89); 18 Mar 2015 09:25:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Mar 2015 09:25:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 84DAFC658C for ; Wed, 18 Mar 2015 09:25:51 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2I9Pnk1022988; Wed, 18 Mar 2015 05:25:50 -0400 Message-ID: <5509449D.2040705@redhat.com> Date: Wed, 18 Mar 2015 09:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH] Reimplement "vFile:fstat" without qSupported References: <1426590248-20310-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1426590248-20310-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00537.txt.bz2 On 03/17/2015 11:04 AM, Gary Benson wrote: > Hi all, > > When I implemented the vFile:fstat packet the other week I didn't > understand how support for the other vFile packets was negotiated. > I implemented it using qSupported to indicate support, which means > the vFile:fstat packet is handled differently from all other vFile > packets--and for no good reason. > > This commit makes support for the vFile:fstat packet be determined > by probing rather than using qSupported. This makes it consistent > with all other vFile packets. > > Built and regtested on RHEL 6.6 x86_64. > > Ok to commit? OK. Thanks, Pedro Alves