From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82502 invoked by alias); 16 Mar 2015 12:35:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82493 invoked by uid 89); 16 Mar 2015 12:35:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 16 Mar 2015 12:35:03 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2GCZ0Do019575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Mar 2015 08:35:00 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2GCYwrw019329; Mon, 16 Mar 2015 08:34:59 -0400 Message-ID: <5506CDF2.4090400@redhat.com> Date: Mon, 16 Mar 2015 12:35:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] watchpoint-reuse-slot.exp: skip some tests on targets have different wp and bp registers References: <1426257692-30461-1-git-send-email-qiyaoltc@gmail.com> In-Reply-To: <1426257692-30461-1-git-send-email-qiyaoltc@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00450.txt.bz2 On 03/13/2015 02:41 PM, Yao Qi wrote: > From: Yao Qi > > watchpoint-reuse-slot.exp sets two hardware breakpoint and/or watchpoint, > to test the same debugging register can be used correctly. However, > on some targets, such as arm and aarch64, hardware has different > registers for breakpoint and watchpoint, so don't have to do test > if one breakpoint and one watchpoint are requested and target hardware > has different debugging registers for breakpoint and watchpoint. Hmm, is this just to save test time? If so, I'd prefer not skipping, as it may always catch other bugs, in the target backends or the kernel. Despite the test's file name, the test doesn't actually create two breakpoints/watchpoints at the same time, as mentioned at the top of the file. In any case: > +# Return true if the same debugging register can be used for both s/can be/is/ > +# watchpoint and breakpoint. > + > +proc dbg_registers_for_watch_and_break {} { I think "same" should be in the proc name: same_dbg_registers_for_watch_and_break > + if { [istarget "arm*-linux*"] || [istarget "aarch64*-*-linux*"] } { > + # arm and aarch64 has different registers for watchpoint and s/has/have/ Thanks, Pedro Alves