From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102427 invoked by alias); 16 Mar 2015 12:09:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102417 invoked by uid 89); 16 Mar 2015 12:09:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 16 Mar 2015 12:09:33 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2GC9OqF001938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Mar 2015 08:09:24 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2GC9MBx016941; Mon, 16 Mar 2015 08:09:23 -0400 Message-ID: <5506C7F2.5040605@redhat.com> Date: Mon, 16 Mar 2015 12:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: John Baldwin , gdb-patches@sourceware.org Subject: Re: [PATCH] Fetch all registers before writing the core register notes. References: <2653052.Cuv9hkMi4i@ralph.baldwin.cx> In-Reply-To: <2653052.Cuv9hkMi4i@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00449.txt.bz2 On 03/14/2015 10:02 PM, John Baldwin wrote: > Without this, not all registers were present in the core generated by gcore. > For example, running 'gcore' on a program without examining the vector > registers (SSE or AVX) would store all the vector registers as zeros because > they were not pulled into the regcache. Running 'info vector' before 'gcore' > would store the correct values in the core since it populated the regcache. > For Linux processes, a similar operation is achieved somewhat by having the > thread iterator callback invoke target_fetch_registers on each thread before > its corresponding register notes are dumped. > > (I don't plan on including that level of detail in the commit log, just as > a way to explain the bug this change fixes.) I think it's good to have the detail in the log. If you felt the need to explain it for review, then a future archaeologist looking at git log/blame would likely appreciate the same info. > gdb/ChangeLog: > > * fbsd-tdep.c (fbsd_make_corefile_notes): Fetch all target registers > before writing core register notes. Looks fine to me. Thanks, Pedro Alves